Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: statistics previous period chart is unclear #3654

Merged
merged 1 commit into from
Oct 2, 2022
Merged

fix: statistics previous period chart is unclear #3654

merged 1 commit into from
Oct 2, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 2, 2022 •
edited
Loading

Fixes #3604

Changes proposed in this pull request:
Improves the statistics chart to be more clear on what the grey line is by adding the name of the line along with the values (Screenshot below).

Reviewers should focus on:
I sneaked in a regionFill for a slight design change 👀

Screenshot

Before After
Screenshot from 2022-10-02 13-13-22 Screenshot from 2022-10-02 13-11-08

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9
fix: statistics previous period chart is unclear
62ec18a 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 self-assigned this Oct 2, 2022
@SychO9 SychO9 requested a review from a team as a code owner October 2, 2022 12:30
@SychO9 SychO9 mentioned this pull request Oct 2, 2022
Closed
davwheat
davwheat approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is soooo much better 🙏

@SychO9 SychO9 merged commit bd0577f into main Oct 2, 2022
@SychO9 SychO9 deleted the sm/stats-chart-previous-peiod branch October 2, 2022 18:43
@SychO9 SychO9 added this to the 1.6 milestone Oct 2, 2022
@luceos luceos mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees

@SychO9 SychO9

Labels
None yet
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

Readme file for Statistics extension?
2 participants
@SychO9 @davwheat