Put m.stream in flarum/utils/stream #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested review from
dsevillamartin,
clarkwinkelmann,
franzliedke and
tankerkiller125
65 tasks
|
I'm a bit confused with the capitalization. It seems the import path is lowercase, but the actual method/object is called If so I think we should use the same capitalization as Mithril for our object. I see this PR already exports it as default with uppercase, but then everywhere the default is imported as lowercase. Alternatively I wouldn't be against calling it |
askvortsov1
force-pushed
the
as/stream-to-utils
branch
from
896a198
to
b4fa7b2
Compare
clarkwinkelmann
approved these changes
Sep 27, 2020
tankerkiller125
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.