Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rust-stable extension #7

Closed
wants to merge 4 commits into from
Closed

Use rust-stable extension #7

wants to merge 4 commits into from

Conversation

barthalion
Copy link
Member

No description provided.

@barthalion
Copy link
Member Author

Hm, looks like I did something wrong. Either way, just a general idea to use rust-stable extension when ImageOptim/gifski#12 gets resolved.

@barthalion barthalion closed this Nov 26, 2017
@phw
Copy link
Collaborator

phw commented Nov 26, 2017

Thanks, last time I checked the org.freedesktop.Sdk.Extension.rust extension was not yet available on Flathub.

One way to solve the networking limitations would be to include a tarball with the vendor resources here (created with cargo-vendor).

@phw
Copy link
Collaborator

phw commented Nov 26, 2017

See also the discussion at flatpak/flatpak-builder#15

I quickly tried cargo vendor locally on the source download. It fills the vendor resources and gives me this to add to the projects .cargo/config:

[source.crates-io]
replace-with = "vendored-sources"

[source."https://github.com/meh/rust-ffmpeg-sys"]
git = "https://github.com/meh/rust-ffmpeg-sys"
branch = "master"
replace-with = "vendored-sources"

[source."https://github.com/pornel/rust-ffmpeg.git"]
git = "https://github.com/pornel/rust-ffmpeg.git"
branch = "master"
replace-with = "vendored-sources"

As this file does not exist I create it. But building with cargo build then fails with:

error: no source URL specified for `source.https://github.com/pornel/rust-ffmpeg.git`, need either `registry` or `local-registry` defined

@kornelski
Copy link

I think support for vendoring of git dependencies has been added very recently, and may not be in a stable build yet.

Try compiling without video?

@phw
Copy link
Collaborator

phw commented Dec 3, 2017

@pornel Thanks for the support. @barthalion actually got this working recently in #8, I just merged the changes.

gifski gets compiled without video anyway here, since the video support is not needed for Peek.

But btw, I also compile it without openmp support, since enabling this gave me segfaults inside Flatpak and also Snap. I have gifski with openmp working fine here on my Arch machine, though. I have not yet opened a bug report yet since I could not find the time to properly debug this :(

@kornelski
Copy link

With OpenMP I've only heard of linking problems (it makes the executable dependent on libgcc and libgomp).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants