Enable gifski #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bot, build |
|
Cool, that's working. I think I can handle this for a start. We should just disable gifski for the ARM architectures with |
phw
reviewed
Nov 27, 2017
| "env": { | ||
| "V": "1" | ||
| "V": "1", | ||
| "CARGO_HOME": "/run/build/gifski/cargo" |
There was a problem hiding this comment.
Is CARGO_HOME actually needed? At least for my local builds using org.freedesktop.Sdk.Extension.rust-stable I could build without it
Closed
|
@barthalion Thanks a lot for the work on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sigh, for some reason I couldn't re-open the old one, so there we go again.
How to recreate
gifski-vendor.tar.xz: use cargo-vendor to createvendordirectory. Next, create.cargo/configwith the content cargo-vendor printed on the exit; change the last line tovendorto make path tosource.vendored-sourcesrelative.Of course the best scenario is upstream doing this themselves for release tarball or at least by you @phw as part of peek release. I added it to git directly to prove that it works.