Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3 compatibility #21

Merged
merged 2 commits into from
Jun 6, 2018
Merged

Fix Python 3 compatibility #21

merged 2 commits into from
Jun 6, 2018

Conversation

jwygoda
Copy link

@jwygoda jwygoda commented Jun 3, 2018

Otherwise, the build fails with an encoding error due to the default locale being ASCII on the Debian builders, not UTF-8. Regardless, this is the recommended approach for writing a setup.py which supports both Python 2 and Python 3.

Similar problem:
pytest-dev/pytest-mock#107

@mongkok
Copy link
Member

mongkok commented Jun 6, 2018

Hi @adogyf,
Thanks for the PR and the reference :), please, fix the import order to merge.

import os
import re
from io import open

@jwygoda
Copy link
Author

jwygoda commented Jun 6, 2018

Thanks for the feedback. I've fixed the import order.

@codecov-io
Copy link

codecov-io commented Jun 6, 2018

Codecov Report

Merging #21 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #21   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         150    150           
  Branches       15     15           
=====================================
  Hits          150    150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6022106...8ec975f. Read the comment docs.

@mongkok mongkok merged commit 08d5f6b into flavors:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants