Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3 compatibility #107

Merged
merged 1 commit into from
Feb 19, 2018
Merged

Conversation

ghisvail
Copy link
Contributor

Otherwise, the build fails with an encoding error due to the default locale being ASCII on the Debian builders, not UTF-8. Regardless, this is the recommended approach for writing a setup.py which supports both Python 2 and Python 3.

@coveralls
Copy link

coveralls commented Feb 19, 2018

Coverage Status

Coverage remained the same at ?% when pulling 9214b5e on ghisvail:patch-1 into 5ceeb05 on pytest-dev:master.

@jurko-gospodnetic
Copy link
Contributor

👍

dotlambda pushed a commit to dotlambda/nixpkgs that referenced this pull request Feb 19, 2018
@nicoddemus
Copy link
Member

Thanks @ghisvail, appreciate it. After we sort out #102 we can make a new release with this.

@nicoddemus nicoddemus merged commit 818f3f5 into pytest-dev:master Feb 19, 2018
FRidh pushed a commit to NixOS/nixpkgs that referenced this pull request Feb 21, 2018
dotlambda pushed a commit to dotlambda/nixpkgs that referenced this pull request Feb 22, 2018
lopsided98 added a commit to lopsided98/nixpkgs that referenced this pull request Feb 25, 2018
Adds a patch that is already applied upstream
(pytest-dev/pytest-mock#107), but has not been
released. This fixes the build with Python 3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants