Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinchzoom regarding gesture center #1081

Merged

Conversation

Zzerr0r
Copy link
Contributor

@Zzerr0r Zzerr0r commented Nov 12, 2021

old behaviour on pinchzoom was to zoom in regarding the map center. now it zooms in regarding the center of the pinch gesture like in google maps for example. I didn't add an option to change between the two as i cant imagine anyone would want to zoom into the center of the map when using pinchzoom.

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 13, 2021
Copy link
Contributor

@ibrierley ibrierley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was looking at this issue today. I think this PR looks good, feels a lot more intuitive and can't see any negatives.

@JaffaKetchup
Copy link
Member

@Zzerr0r Please pull upstream when possible, then I (or another maintainer) can merge after running the checks.

@github-actions github-actions bot removed the Stale label Jan 30, 2022
@JaffaKetchup
Copy link
Member

@Zzerr0r Please pull upstream, then we should be ready to go!

@JaffaKetchup
Copy link
Member

@Zzerr0r Please pull upstream, so I can run the checks. Then this should be ready to go! Otherwise, I will have to close this pull request due to inactivity,

@JaffaKetchup JaffaKetchup self-assigned this Feb 20, 2022
@Zzerr0r
Copy link
Contributor Author

Zzerr0r commented Feb 20, 2022

I'm sorry, I don't really know how to do that, couldn't you just integrate the changes manually? it's only like 4 lines of code in one file

@JaffaKetchup
Copy link
Member

@Zzerr0r
I can if you can't, but it's simple I think.

  1. Go to your fork and branch.
  2. Look at the bar where it says "This branch is x commits ahead, y commit behind fleaflet:master"
  3. Click "Fetch upstream", then "Fetch and merge"

If your not confident enough, edit this PR (in the PR options) to allow edits by maintainers.

@JaffaKetchup
Copy link
Member

JaffaKetchup commented Feb 20, 2022

@Zzerr0r
Thanks for doing that. Now I can see that there are some formatting issues in the file you changed. This should be a simple fix: could you please run dart format --fix in your console on the branch. When the checks don't fail, I will merge ASAP, as there is already a review.

If I was to do this manually, you would lose credit, and another maintainer would need to merge my PR. So it's easier to do it here; sorry for all the hassle!

@Zzerr0r
Copy link
Contributor Author

Zzerr0r commented Feb 20, 2022

No worries at all, glad I could help, I just didn't really know what to do for a while for pulling upstream. I'm super thankful that this library exists and I feel cool contributing. I also think It's super nice that you're active now again! Thanks :)

@JaffaKetchup JaffaKetchup merged commit 0b5b804 into fleaflet:master Feb 20, 2022
@JaffaKetchup
Copy link
Member

JaffaKetchup commented Feb 20, 2022

Thanks for your contribution, it's greatly appreciated :)

@Zzerr0r Zzerr0r deleted the pinchzoom-regarding-gesture-center branch February 20, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants