-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinchzoom regarding gesture center #1081
Pinchzoom regarding gesture center #1081
Conversation
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was looking at this issue today. I think this PR looks good, feels a lot more intuitive and can't see any negatives.
@Zzerr0r Please pull upstream when possible, then I (or another maintainer) can merge after running the checks. |
@Zzerr0r Please pull upstream, then we should be ready to go! |
@Zzerr0r Please pull upstream, so I can run the checks. Then this should be ready to go! Otherwise, I will have to close this pull request due to inactivity, |
I'm sorry, I don't really know how to do that, couldn't you just integrate the changes manually? it's only like 4 lines of code in one file |
@Zzerr0r
If your not confident enough, edit this PR (in the PR options) to allow edits by maintainers. |
…ng-gesture-center
@Zzerr0r If I was to do this manually, you would lose credit, and another maintainer would need to merge my PR. So it's easier to do it here; sorry for all the hassle! |
No worries at all, glad I could help, I just didn't really know what to do for a while for pulling upstream. I'm super thankful that this library exists and I feel cool contributing. I also think It's super nice that you're active now again! Thanks :) |
Thanks for your contribution, it's greatly appreciated :) |
old behaviour on pinchzoom was to zoom in regarding the map center. now it zooms in regarding the center of the pinch gesture like in google maps for example. I didn't add an option to change between the two as i cant imagine anyone would want to zoom into the center of the map when using pinchzoom.