Center zoom on pinch zoom gesture (not just on move gesture) #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
JaffaKetchup
approved these changes
Jun 4, 2023
There was a problem hiding this comment.
LGTM, thanks @JosefWN. I can't test this myself, but if this same technique is used elsewhere, I don't see why it shouldn't be used here.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the last issue tracked in #1354. #1081 seems to omit the pinch to zoom case. I tried adding it and it seems to be working on MacOS now, but I haven't tested extensively to see if this change breaks anything else.
EDIT: To clarify, on MacOS,
_pinchMoveStartedis not true when I'm pinching to zoom. Combined gestures are not supported on the touchpad, so it's either zoom, move or rotate.This is also taken into account here, for example: https://github.com/fleaflet/flutter_map/blob/master/lib/src/gestures/gestures.dart#L458