-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically install software - BE: Policy automations #21428
Labels
Milestone
Comments
lukeheath
added
:product
Product Design department (shows up on 🦢 Drafting board)
:release
Ready to write code. Scheduled in a release. See "Making changes" in handbook.
~backend
Backend-related issue.
#g-endpoint-ops
Endpoint ops product group
P2
Prioritize as urgent
~sub-task
A technical sub-task that is part of a story. (Not QA'd. Not estimated.)
and removed
:product
Product Design department (shows up on 🦢 Drafting board)
labels
Aug 20, 2024
This was referenced Aug 28, 2024
Closed
lucasmrod
added a commit
that referenced
this issue
Aug 30, 2024
#21428 - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [X] Added/updated tests - [X] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [X] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [X] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [X] Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). - [X] Manual QA for all new/changed functionality
This was referenced Aug 30, 2024
lucasmrod
added a commit
that referenced
this issue
Aug 30, 2024
Small fix for #21428. This is to show the activity the right way (Because installations triggered by Fleet will have `host_software_installs` with `NULL` `user_id`.).
lucasmrod
added a commit
that referenced
this issue
Aug 30, 2024
#21428 Figma: https://www.figma.com/design/4pfUOYy7IyMIrjMH2fuCdU/%2319551-Policy-automations%3A-install-software?node-id=5871-12100&t=pKh926u8a30iYFBA-4 - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [X] Added/updated tests - [X] Manual QA for all new/changed functionality
@xpkoala Added notes for QA. |
@xpkoala Just a heads up there are QA notes here (since you may not look at the sub-task). |
Fleet installs with grace, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Story: #19551.
QA notes
20240829170024 - PolicyAutomaticInstallSoftware
).go run ./cmd/osquery-perf -enroll_secret <...> -os_templates=windows_11.tmpl:1,macos_14.1.2.tmpl:1,ubuntu_22.04.tmpl:1 -host_count 3 -software_installer_install_fail_prob .25 -policy_pass_prob 0.5
.Other tests:
A package already installed on the host and a failing policy should not queue an install request.A package already installed on the host will make the policy pass and therefore an install request won’t be queued.Packages for testing
These are the packages + policy SQLs that I used to test the feature the way our users will use it.
macOS
Microsoft Teams
SELECT 1 FROM apps WHERE name = 'Microsoft Teams.app' AND version_compare(bundle_short_version, '24193.1707.3028.4282') >= 0;
Firefox
SELECT 1 FROM apps WHERE name = 'Firefox.app' AND version_compare(bundle_short_version, '129.0.2') >= 0;
Windows
Tailscale
exe
s doesn't work, script:SELECT 1 FROM programs WHERE name = 'Tailscale' AND version_compare(version, '1.72.0') >= 0;
Firefox
SELECT 1 FROM programs WHERE name = 'Mozilla Firefox (x64 en-US)' AND version_compare(version, '129.0.2') >= 0;
Linux
1Password
SELECT 1 FROM deb_packages WHERE name = '1password' AND version_compare(version, '8.10.39') >= 0;
sudo apt purge --remove 1password
.Firefox
SELECT 1 FROM deb_packages WHERE name = 'firefox' AND version_compare(version, '129.0.2') >= 0;
The text was updated successfully, but these errors were encountered: