Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear policy results and stats when setting or changing an installer #22053

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

lucasmrod
Copy link
Member

@lucasmrod lucasmrod commented Sep 12, 2024

Follow up PR for #21428.

After some discussions with Noah we want to clear policy results when a user sets for the first time or changes an installer on a policy.

Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmrod lucasmrod merged commit 169d9de into main Sep 12, 2024
18 of 19 checks passed
@lucasmrod lucasmrod deleted the 21467-policies-for-no-team-clear-results branch September 12, 2024 19:56
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.36%. Comparing base (3541ad6) to head (79a8304).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22053      +/-   ##
==========================================
+ Coverage   55.82%   65.36%   +9.53%     
==========================================
  Files        1494     1494              
  Lines      116479   116503      +24     
  Branches     3540     3540              
==========================================
+ Hits        65030    76157   +11127     
+ Misses      45202    33255   -11947     
- Partials     6247     7091     +844     
Flag Coverage Δ
backend 66.69% <100.00%> (+10.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants