Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIS Benchmarks: Add macOS 15 and update macOS 13 & 14 #23611

Closed
16 of 19 tasks
noahtalerman opened this issue Nov 7, 2024 · 8 comments
Closed
16 of 19 tasks

CIS Benchmarks: Add macOS 15 and update macOS 13 & 14 #23611

noahtalerman opened this issue Nov 7, 2024 · 8 comments
Assignees
Labels
#g-endpoint-ops Endpoint ops product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature

Comments

@noahtalerman
Copy link
Member

noahtalerman commented Nov 7, 2024

Goal

User story
As an endpoint engineer,
I want Fleet to support the latest macOS CIS Benchmarks
so that I can be sure I'm using the latest version of the benchmarks to meet compliance needs.

Objective

None. Fleet is committed to maintaining CIS Benchmarks for Windows and Mac workstations.

Original requests

Context

Changes

Product

  • CIS policies changes: Add policies for macOS 15 to cover v1.0.0. Update the macOS 13 CIS policies to cover v3.0.0. Update macOS 14 to cover v2.0.0.
  • Feature guide changes: Add mention of macOS 15 to the the CIS Benchmarks guide here.
  • Other reference documentation changes:
    • Update the macOS 13 and macOS 14 READMEs to call out that Fleet's policies are written using v3.0.0 and v2.0.0 respectively.
    • Add a macOS 15 README
  • UI changes: No changes
  • CLI (fleetctl) usage changes: No changes
  • YAML changes: No changes
  • REST API changes: No changes
  • Fleet's agent (fleetd) changes: No changes
  • Activity changes: No changes
  • Permissions changes: No changes
  • Changes to paid features or tiers: No changes
  • Once shipped, requester has been notified

Engineering

  • Database schema migrations: not needed
  • Load testing: not needed
  • Compare and diff the new document/s and change our CIS policies accordingly. (Add/Modify/Delete)

Links to CIS documents:
macOS 15.0 v1.0.0 Sequoia
macOS 14.0 v2.0.0 Sonoma
macOS 13.0 v3.0.0 Ventura

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Requires load testing: TODO
  • Risk level: Low / High TODO
  • Risk description: TODO

Manual testing steps

  1. Step 1
  2. Step 2
  3. Step 3

Testing notes

Confirmation

  1. Engineer (@____): Added comment to user story confirming successful completion of QA.
  2. QA (@____): Added comment to user story confirming successful completion of QA.
@noahtalerman noahtalerman added story A user story defining an entire feature :product Product Design department (shows up on 🦢 Drafting board) #g-endpoint-ops Endpoint ops product group labels Nov 7, 2024
@sharon-fdm
Copy link
Collaborator

Estimated with @defensivedepth to be done by the end of November.

@sharon-fdm sharon-fdm added :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed :product Product Design department (shows up on 🦢 Drafting board) labels Nov 12, 2024
@sharon-fdm sharon-fdm added :product Product Design department (shows up on 🦢 Drafting board) and removed :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. labels Dec 6, 2024
@noahtalerman
Copy link
Member Author

The following controls were not added, further research on how to check them with osquery is required:

  • 2.6.3.1 - 2.6.3.5 and 2.7.2: I am not sure how we can accomplish this.
  • "5.11 - Ensure Logging Is Enabled For Sudo" I believe this one can be accomplished through the file_lines table

Hey @defensivedepth, I'm looking at your comment from your PR here (also above).

This means we should add these to the "Limitations" section in the macOS 15 README right?

cc @sharon-fdm

@sharon-fdm
Copy link
Collaborator

@noahtalerman, yes. It's mentioned here.

@defensivedepth is still working on them to be added next sprint.

@noahtalerman
Copy link
Member Author

@noahtalerman, yes. It's mentioned here.

@sharon-fdm I think the list you linked to is missing 2.6.3.5 and 2.7.2:

Screenshot 2024-12-10 at 10 01 51 AM

(the above screenshot from Josh's PR description here)

We should add those to the "Missing items" list too, right?

@sharon-fdm
Copy link
Collaborator

@noahtalerman, yes, thanks! I'll check.

noahtalerman added a commit that referenced this issue Dec 10, 2024
CIS Benchmarks for macOS 15 were added in this user story: #23611
@noahtalerman
Copy link
Member Author

@sharon-fdm I think the list you linked to is missing 2.6.3.5 and 2.7.2:

Screenshot 2024-12-10 at 10 01 51 AM

(the above screenshot from Josh's PR description here)

We should add those to the "Missing items" list too, right?

@sharon-fdm I opened a PR to add the missing items here: #24645

I also opened a user story so that we can track the work Josh is doing to add support for those missing items: #24647

Sharon, I assigned that story to you and moved it to "Ready to spec"

FYI @defensivedepth

@noahtalerman
Copy link
Member Author

Hey @sharon-fdm just giving you another ping! can you please review my PR when you get the chance? #24645

@fleet-release
Copy link
Contributor

Updated benchmarks shine,
Mac compliance needs aligned,
Fleet's support refined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#g-endpoint-ops Endpoint ops product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature
Development

No branches or pull requests

4 participants