Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Follow directions in My device" banner shows up on host info pages where it shouldn't #24248

Closed
iansltx opened this issue Dec 1, 2024 · 7 comments
Closed

"Follow directions in My device" banner shows up on host info pages where it shouldn't #24248

iansltx opened this issue Dec 1, 2024 · 7 comments
Assignees
@jacobshandling
Labels
bug Something isn't working as documented ~frontend Frontend-related issue. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone
4.61.0

Comments

@iansltx
Copy link
Member

iansltx commented Dec 1, 2024

Fleet version: 4.60

💥  Actual behavior

"Ask the user to follow Disk encryption instructions on their My device page" banner shows up on non-Linux hosts.

🧑‍💻  Steps to reproduce

  1. Enroll a non-Linux host with an encrypted disk where the key hasn't yet been escrowed
  2. View the host's details page

Or see it in Dogfood

🛠️ To fix

Make sure the banner doesn't show up for non-Linux platforms.
@iansltx iansltx added #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. bug Something isn't working as documented ~frontend Frontend-related issue. ~released bug This bug was found in a stable release. labels Dec 1, 2024
@iansltx iansltx mentioned this issue Dec 1, 2024
Closed
@sharon-fdm
Copy link
Collaborator

@jacobshandling, @RachelElysia, is this a low-hanging-fruit fix?

@jacobshandling
Copy link
Contributor

Isn't this expected behavior? If we don't have the key for Mac or Windows, we want the user to follow whatever steps so that we have the key escrowed right @noahtalerman?

@jacobshandling jacobshandling self-assigned this Dec 2, 2024
@jacobshandling
Copy link
Contributor

Confirmed it's a bug

@jacobshandling
Copy link
Contributor

Stemmed from misunderstanding that only Linux hosts could have the disk encrypted but not the key escrowed, when in fact that state is possible for Windows hosts as well.

@jacobshandling jacobshandling mentioned this issue Dec 2, 2024
Merged
2 tasks
@iansltx
Copy link
Member Author

iansltx commented Dec 2, 2024

Just realized another nuance of this: @noahtalerman should we be showing this at all if disk encryption isn't enforced for that host's team? i.e. if encryption isn't enforced, we shouldn't be nudging people to escrow keys, right?

@iansltx
Copy link
Member Author

iansltx commented Dec 2, 2024

Never mind, covered in

fleet/frontend/pages/hosts/details/HostDetailsPage/components/HostDetailsBanners/HostDetailsBanners.tsx

Line 116 in 8e33b73

diskEncryptionOSSetting?.status
.

jacobshandling added a commit that referenced this issue Dec 3, 2024
@jacobshandling
UI - Only show 'follow instructions on My device' banner for encrypte…
ed8c3a3 
…d and non-escrowed Linux hosts (#24277)

## #24248

For hosts with encrypted disks that Fleet does not have a key escrowed
for:

**Banner shown for Linux:**
<img width="1464" alt="Screenshot 2024-12-02 at 10 52 08 AM"
src="https://github.com/user-attachments/assets/91dd3b64-b9da-430b-9eb0-0ae30af751d8">

**but not for Windows:**
<img width="1464" alt="Screenshot 2024-12-02 at 10 49 54 AM"
src="https://github.com/user-attachments/assets/0345db0d-74f5-4608-af7b-58efae14dfea">



- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
parsimeikoikai pushed a commit to parsimeikoikai/fleet that referenced this issue Dec 3, 2024
@jacobshandling @parsimeikoikai
UI - Only show 'follow instructions on My device' banner for encrypte…
9d049e1 
…d and non-escrowed Linux hosts (fleetdm#24277)

## fleetdm#24248

For hosts with encrypted disks that Fleet does not have a key escrowed
for:

**Banner shown for Linux:**
<img width="1464" alt="Screenshot 2024-12-02 at 10 52 08 AM"
src="https://github.com/user-attachments/assets/91dd3b64-b9da-430b-9eb0-0ae30af751d8">

**but not for Windows:**
<img width="1464" alt="Screenshot 2024-12-02 at 10 49 54 AM"
src="https://github.com/user-attachments/assets/0345db0d-74f5-4608-af7b-58efae14dfea">



- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA

---------

Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
@sharon-fdm sharon-fdm added this to the 4.61.0-tentative milestone Dec 3, 2024
@fleet-release
Copy link
Contributor

Banner, misplaced, fixed,
Host pages now clear, specific,
Ease for every click.

@sharon-fdm sharon-fdm removed the #g-endpoint-ops Endpoint ops product group label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobshandling jacobshandling

Labels
bug Something isn't working as documented ~frontend Frontend-related issue. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Projects
None yet
Milestone
4.61.0
Development

No branches or pull requests
5 participants
@iansltx @lukeheath @jacobshandling @fleet-release @sharon-fdm