UI - Only show 'follow instructions on My device' banner for encrypted and non-escrowed Linux hosts #24277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobshandling
had a problem deploying
to
Docker Hub
GitHub Actions
Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24277 +/- ##
==========================================
- Coverage 63.41% 63.41% -0.01%
==========================================
Files 1580 1580
Lines 150207 150212 +5
Branches 3730 3786 +56
==========================================
Hits 95259 95259
- Misses 47354 47359 +5
Partials 7594 7594
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
jacobshandling
changed the title
|
Will add some tests for these banners after higher priority P2 code/reviews |
jacobshandling
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
iansltx
reviewed
Dec 2, 2024
...end/pages/hosts/details/HostDetailsPage/components/HostDetailsBanners/HostDetailsBanners.tsx
Show resolved
Hide resolved
iansltx
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Looks like component names don't match up, which is why JS tests are failing. Logic LGTM but I'll defer to @RachelElysia on approval after tests pass.
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
|
Ah, accidentally included WIP tests that I hadn't implemented yet, hence broken build – should be good now @iansltx |
parsimeikoikai
pushed a commit
to parsimeikoikai/fleet
that referenced
this pull request
Dec 3, 2024
…d and non-escrowed Linux hosts (fleetdm#24277) ## fleetdm#24248 For hosts with encrypted disks that Fleet does not have a key escrowed for: **Banner shown for Linux:** <img width="1464" alt="Screenshot 2024-12-02 at 10 52 08 AM" src="https://github.com/user-attachments/assets/91dd3b64-b9da-430b-9eb0-0ae30af751d8"> **but not for Windows:** <img width="1464" alt="Screenshot 2024-12-02 at 10 49 54 AM" src="https://github.com/user-attachments/assets/0345db0d-74f5-4608-af7b-58efae14dfea"> - [x] Changes file added for user-visible changes in `changes/` - [x] Manual QA --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24248
For hosts with encrypted disks that Fleet does not have a key escrowed for:
Banner shown for Linux:
but not for Windows:
changes/