Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSVL: Update Delete label copy #24537

Open
georgekarrv opened this issue Dec 9, 2024 · 0 comments
Open

SSVL: Update Delete label copy #24537

georgekarrv opened this issue Dec 9, 2024 · 0 comments
Assignees
@ghernandez345
Labels
~frontend Frontend-related issue. #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.)
Milestone
4.62.0-tentative

Comments

@georgekarrv
Copy link
Member

georgekarrv commented Dec 9, 2024 •
edited by mna
Loading

Also requires handling the new error message, the backend will return 422 with this body:

{
  "message": "Validation Failed",
  "errors": [
    {
      "name": "base",
      "reason": "the operation violates a foreign key constraint on labels: foo"
    }
  ],
  "uuid": "384f4c14-7268-407c-ae72-50f6456b6423"
}
@georgekarrv georgekarrv added :product Product Design department (shows up on 🦢 Drafting board) #g-mdm MDM product group ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.) ~backend Backend-related issue. ~frontend Frontend-related issue. :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. and removed ~backend Backend-related issue. :product Product Design department (shows up on 🦢 Drafting board) labels Dec 9, 2024
@mna mna mentioned this issue Dec 11, 2024
Merged
4 tasks
@georgekarrv georgekarrv added this to the 4.62.0-tentative milestone Dec 11, 2024
@ghernandez345 ghernandez345 self-assigned this Dec 15, 2024
@ghernandez345 ghernandez345 mentioned this issue Dec 16, 2024
Merged
3 tasks
ghernandez345 added a commit that referenced this issue Dec 17, 2024
@ghernandez345
Add UI for scoping software to fleet apps and custom packages via lab…
0876a9d 
…els (#24793)

relates to #24538, #24542, #24540, #24537

implements the UI for scoping software to fleet maintained apps and
custom packages. This includes:

**adding custom target label selection to fleet maintained app form**

<img width="824" alt="image"
src="https://github.com/user-attachments/assets/b0e18841-e5c5-406a-b83f-ce2b5a8f8472"
/>

**adding custom target label selection to custom package form**

<img width="821" alt="image"
src="https://github.com/user-attachments/assets/06279121-69bd-4663-aebd-930cd7c02190"
/>

***adding custom target label selection on edit software modals**

<img width="796" alt="image"
src="https://github.com/user-attachments/assets/c15a8236-1b02-4d17-9245-e24967190eaf"
/>

also includes various small copy changes.

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
- [ ] Added/updated tests
- [x] Manual QA for all new/changed functionality
@ghernandez345 ghernandez345 mentioned this issue Dec 19, 2024
Merged
1 task
ghernandez345 added a commit that referenced this issue Dec 19, 2024
@ghernandez345
update the label error message (#24932)
863e680 
relates to #24537

updates the delete label error when label is used for software

- [x] Manual QA for all new/changed functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghernandez345 ghernandez345

Labels
~frontend Frontend-related issue. #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~sub-task A technical sub-task that is part of a story. (Not QA'd. Not estimated.)
Milestone
4.62.0-tentative
Development

No branches or pull requests
2 participants
@ghernandez345 @georgekarrv