Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for scoping software to fleet apps and custom packages via labels #24793

Merged
merged 15 commits into from
Dec 17, 2024

Conversation

ghernandez345
Copy link
Contributor

relates to #24538, #24542, #24540, #24537

implements the UI for scoping software to fleet maintained apps and custom packages. This includes:

adding custom target label selection to fleet maintained app form

image

adding custom target label selection to custom package form

image

*adding custom target label selection on edit software modals

image

also includes various small copy changes.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 12.24490% with 43 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-labels-scoped-software@12bf988). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...onents/TargetLabelSelector/TargetLabelSelector.tsx 16.21% 31 Missing ⚠️
frontend/services/entities/software.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat-labels-scoped-software   #24793   +/-   ##
==============================================================
  Coverage                               ?   63.55%           
==============================================================
  Files                                  ?     1603           
  Lines                                  ?   151812           
  Branches                               ?     3880           
==============================================================
  Hits                                   ?    96484           
  Misses                                 ?    47650           
  Partials                               ?     7678           
Flag Coverage Δ
frontend 53.59% <12.24%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghernandez345 ghernandez345 merged commit 0876a9d into feat-labels-scoped-software Dec 17, 2024
11 checks passed
@ghernandez345 ghernandez345 deleted the feat-ui-fleet-apps-labels branch December 17, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants