-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI for scoping software to fleet apps and custom packages via labels #24793
Add UI for scoping software to fleet apps and custom packages via labels #24793
Conversation
be899ef
to
c658156
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-labels-scoped-software #24793 +/- ##
==============================================================
Coverage ? 63.55%
==============================================================
Files ? 1603
Lines ? 151812
Branches ? 3880
==============================================================
Hits ? 96484
Misses ? 47650
Partials ? 7678
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c658156
to
ed0be6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
relates to #24538, #24542, #24540, #24537
implements the UI for scoping software to fleet maintained apps and custom packages. This includes:
adding custom target label selection to fleet maintained app form
adding custom target label selection to custom package form
*adding custom target label selection on edit software modals
also includes various small copy changes.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.