-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MDM migration flow with offline dialog #21209
Closed
gillespi314
wants to merge
96
commits into
feat-mdm-migration-updates
from
mdm-migration-offline-watcher
Closed
Update MDM migration flow with offline dialog #21209
gillespi314
wants to merge
96
commits into
feat-mdm-migration-updates
from
mdm-migration-offline-watcher
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstallers that have an install request on the host (#21083)
Covers a case brought up in a question in #20875 This covers a case that was already handled by code, but not tested
…l request once host is moved/installer is deleted (#21064)
Fix for #21013 and other fixes found while testing VPP apps with iOS/iPadOS/macOS devices. Regarding the change in ListSoftwareTitles with `TeamID=nil`, from Noah: #19447 (comment)
…date for SW title details w/o versions (#21098) ## Parts 1b and 2 for #21053 1b: <img width="1502" alt="Screenshot 2024-08-06 at 12 14 30 PM" src="https://github.com/user-attachments/assets/19dc67ca-adde-49ff-a884-b9ebaa15b1d7"> 2: <img width="1502" alt="Screenshot 2024-08-06 at 12 13 28 PM" src="https://github.com/user-attachments/assets/951bdf0b-adfc-41a1-b668-2d0b53addbe4"> - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling <jacob@fleetdm.com>
I have updated the list of tutorials and guides in the docs. Although the brief stated the cut down the list to only the top 10, @nonpunctual and I whittled the list down to curate the top 20 guides that we believe are relevant to users who are deploying and setting up Fleet. We listed them in order of operation as much as possible. Closes fleetdm/confidential#7343
- Update sentence to be clearer
…21035) Revising per https://fleetdm.com/handbook/company/communications#times (and for accuracy, as we're currently in CDT)
Same issue as my previous PR, just a little further down the page.
Checked in GitHub preview. Previously "Numbers over three digits" got appended to "All-in-one platform" because Markdown
Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>
In addition to a word choice issue (first line fixed), there were a couple of passive-voice/missing punctuation issues later in the table, so figured I might as well clean those up. If the active voice isn't right here for how the process actually goes, bonus points for me learning something :) --------- Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>
Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>
…ager" instructions (#21123)
#20929 Moving Go integration tests to integration test job, which runs tests that start with `TestIntegrations` Test changes only. No product changes
…lf-Service (#21127) #20181 In Fleet Desktop, My Device status is now refreshed when user clicks on My Device or Self-Service dropdown option. Demo: https://www.loom.com/share/7c5968b8ed1a481a8ffd46e8fdac1ea4 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [ ] Added/updated tests - [x] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [x] Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
#21038 Fleet server now accepts arguments via stdin. This is useful for passing secrets that you don't want to expose as env vars, in the command line, or in the config file. Demo: https://www.loom.com/share/c8b4dc6ae6ef4182bc812d7f43423f4d # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
> No issue, just a tiny bug I noticed while testing in dogfood Saw a missing open paren in this tooltip: ![Screenshot 2024-08-07 at 9 22 38 AM](https://github.com/user-attachments/assets/018d9387-70d9-4877-bfe5-5654c7acb5d2) # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Manual QA for all new/changed functionality
Migration for #19882 Making the migration its own PR so it doesn't become stale.
- created new template fleet.servicename - reference in all locations that contain service name Resolves #20830. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Manual QA for all new/changed functionality
…eetdm/fleet into mdm-migration-offline-watcher
gillespi314
requested review from
lukeheath,
georgekarrv,
sharon-fdm,
Sampfluger88,
mikermcneil,
eashaw,
rfairburn,
ksatter,
edwardsb,
a team,
jacobshandling and
mostlikelee
as code owners
August 13, 2024 15:22
Replaced by #21274 (because the commit history got all messed up by a bad rebase attempt) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.
SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)cmd/osquery-perf
for new osquery data ingestion features.COLLATE utf8mb4_unicode_ci
).runtime.GOOS
).