-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/feat: make SearchBar
's view height adjustable; add new properties
#4039
Conversation
Reviewer's Guide by SourceryThis pull request enhances the Updated class diagram for the SearchBar componentclassDiagram
class SearchBar {
+OptionalNumber view_header_height
+Optional[BoxConstraints] view_size_constraints
+Union[None, str, Dict[ControlState, str]] bar_shadow_color
+Union[None, str, Dict[ControlState, str]] bar_surface_tint_color
+Union[OptionalNumber, Dict[ControlState, Number]] bar_elevation
+Union[None, BorderSide, Dict[ControlState, BorderSide]] bar_border_side
+Union[None, OutlinedBorder, Dict[ControlState, OutlinedBorder]] bar_shape
+Union[None, TextStyle, Dict[ControlState, TextStyle]] bar_text_style
+Union[None, TextStyle, Dict[ControlState, TextStyle]] bar_hint_text_style
+Union[PaddingValue, Dict[ControlState, PaddingValue]] bar_padding
+OptionalControlEventCallable on_tap_outside_bar
}
class BoxConstraints {
+OptionalNumber min_width
+OptionalNumber min_height
+OptionalNumber max_width
+OptionalNumber max_height
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@sourcery-ai review |
SearchBar
's view height adjustableSearchBar
's view height adjustable; add new properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ndonkoHenri - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Hi, |
They are available in the latest prerelease: |
* main: (31 commits) Migrate `colors` and `icons` variables to Enums (flet-dev#4180) feat: expose more properties in Controls (flet-dev#4105) feat!: Refactor `Badge` Control to a Dataclass; create new `Control.badge` property (flet-dev#4077) fix: clicking on `CupertinoContextMenuAction` doesn't close context menu (flet-dev#3948) fix dropdown `max_menu_height` (flet-dev#3974) Fix undefined name "Future" --> asyncio.Future (flet-dev#4230) wrap ListTile in material widget (flet-dev#4206) Update CONTRIBUTING.md (flet-dev#4208) TextField: suffix_icon, prefix_icon and icon can be Control or str (flet-dev#4173) feat!: enhance `Map` control (flet-dev#3994) skip running flutter doctor on windows if no_rich_output is True (flet-dev#4108) add --pyinstaller-build-args to pack cli command (flet-dev#4187) fix/feat: make `SearchBar`'s view height adjustable; add new properties (flet-dev#4039) fix: prevent button `style` from being modified in `before_update()` (flet-dev#4181) fix: disabling filled buttons is not visually respected (flet-dev#4090) when `label` is set, use `MainAxisSize.min` for the `Row` (flet-dev#3998) fix: `NavigationBarDestination.disabled` has no visual effect (flet-dev#4073) fix autofill in CupertinoTextField (flet-dev#4103) Linechart: jsonDecode tooltip before displaying (flet-dev#4069) fixed bgcolor, color and elevation (flet-dev#4126) ...
@ndonkoHenri import flet as ft def main(page: ft.Page): ft.app(target=main, view=ft.AppView.WEB_BROWSER)**** |
@ClearSafety i opened an issue: #4767 |
Description
Fixes #3985 #4081
Test Code
Summary by Sourcery
Fix the
SearchBar
component to make its view height adjustable and enhance it by adding properties for view size constraints and header height, allowing for more flexible layout configurations.Bug Fixes:
SearchBar
component by making its view height adjustable.Enhancements:
view_size_constraints
andview_header_height
properties in theSearchBar
component to allow more flexible layout configurations.Summary by Sourcery
Make the
SearchBar
component's view height adjustable and enhance its flexibility by adding new properties for layout and style customization. Introduce utility functions for parsing widget state properties to support dynamic configurations.Bug Fixes:
SearchBar
component by making its view height adjustable.Enhancements:
view_size_constraints
andview_header_height
properties in theSearchBar
component to allow more flexible layout configurations.SearchBar
such asbar_shadow_color
,bar_surface_tint_color
,bar_elevation
,bar_border_side
,bar_shape
,bar_text_style
,bar_hint_text_style
, andbar_padding
to enhance customization options.parseWidgetStateDouble
,parseWidgetStateInt
,parseWidgetStateBool
,parseWidgetStateEdgeInsets
,parseWidgetStateOutlinedBorder
, andparseWidgetStateTextStyle
to support dynamic property handling.