-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextField: suffix_icon, prefix_icon and icon can be Control or str #4173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prefix_icon of IconValue type in python
Do we need to add that to Dropdown and other controls using |
FeodorFitsner
approved these changes
Oct 18, 2024
pengwon
added a commit
to pengwon/flet
that referenced
this pull request
Oct 30, 2024
* main: (31 commits) Migrate `colors` and `icons` variables to Enums (flet-dev#4180) feat: expose more properties in Controls (flet-dev#4105) feat!: Refactor `Badge` Control to a Dataclass; create new `Control.badge` property (flet-dev#4077) fix: clicking on `CupertinoContextMenuAction` doesn't close context menu (flet-dev#3948) fix dropdown `max_menu_height` (flet-dev#3974) Fix undefined name "Future" --> asyncio.Future (flet-dev#4230) wrap ListTile in material widget (flet-dev#4206) Update CONTRIBUTING.md (flet-dev#4208) TextField: suffix_icon, prefix_icon and icon can be Control or str (flet-dev#4173) feat!: enhance `Map` control (flet-dev#3994) skip running flutter doctor on windows if no_rich_output is True (flet-dev#4108) add --pyinstaller-build-args to pack cli command (flet-dev#4187) fix/feat: make `SearchBar`'s view height adjustable; add new properties (flet-dev#4039) fix: prevent button `style` from being modified in `before_update()` (flet-dev#4181) fix: disabling filled buttons is not visually respected (flet-dev#4090) when `label` is set, use `MainAxisSize.min` for the `Row` (flet-dev#3998) fix: `NavigationBarDestination.disabled` has no visual effect (flet-dev#4073) fix autofill in CupertinoTextField (flet-dev#4103) Linechart: jsonDecode tooltip before displaying (flet-dev#4069) fixed bgcolor, color and elevation (flet-dev#4126) ...
@sourcery-ai review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Properties
suffix_icon
,prefix_icon
andicon
now accept both strings (icon name) and Controls.Fixes #4161
The alignment of suffix and suffix_icon is still different but that's how it is done in Flutter. Now control can be placed into suffix_icon or suffix or both and user can choose which layout better for their app.
Test Code
Type of change
Checklist:
Screenshots (if applicable):
Additional details