Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextField: suffix_icon, prefix_icon and icon can be Control or str #4173

Merged
merged 10 commits into from
Oct 19, 2024

Conversation

InesaFitsner
Copy link
Contributor

Description

Properties suffix_icon, prefix_icon and icon now accept both strings (icon name) and Controls.

Fixes #4161

The alignment of suffix and suffix_icon is still different but that's how it is done in Flutter. Now control can be placed into suffix_icon or suffix or both and user can choose which layout better for their app.

Test Code

import flet as ft

def main(page: ft.Page):
       
    txtfield1 = ft.TextField(
        width=400,
        value='Default value',
        #text_size=10,
        icon=ft.icons.ARROW_DROP_DOWN,
        prefix_icon=ft.icons.ARROW_DROP_DOWN,
        prefix = ft.Icon(ft.icons.ARROW_DROP_DOWN),
        bgcolor=ft.colors.AMBER_100,
        text_vertical_align=ft.VerticalAlignment.CENTER,
        suffix_icon = ft.icons.ARROW_DROP_DOWN,
        suffix = ft.Icon(ft.icons.ARROW_DROP_DOWN),
    )

    txtfield2 = ft.TextField(
        width=400,
        value='Default value',
        #text_size=10,
        icon=ft.Container(bgcolor=ft.colors.RED, height=10, width=10),
        prefix_icon=ft.Container(bgcolor=ft.colors.RED, height=10, width=10),
        prefix = ft.Container(bgcolor=ft.colors.RED, height=10, width=10),
        bgcolor=ft.colors.AMBER_100,
        text_vertical_align=ft.VerticalAlignment.CENTER,
        suffix_icon = ft.Container(bgcolor=ft.colors.RED, height=10, width=10),
        suffix = ft.Container(bgcolor=ft.colors.RED, height=10, width=10),
    )


    page.add(ft.Row([txtfield1, txtfield2]))

ft.app(target=main)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I signed the CLA.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have made corresponding changes to the documentation (if applicable)

Screenshots (if applicable):

Additional details

@FeodorFitsner
Copy link
Contributor

Do we need to add that to Dropdown and other controls using buildInputDecoration()?

@FeodorFitsner FeodorFitsner merged commit 43f6cf4 into main Oct 19, 2024
2 checks passed
@FeodorFitsner FeodorFitsner deleted the inesa/textfield-suffix-bug branch October 19, 2024 21:11
pengwon added a commit to pengwon/flet that referenced this pull request Oct 30, 2024
* main: (31 commits)
  Migrate `colors` and `icons` variables to Enums (flet-dev#4180)
  feat: expose more properties in Controls (flet-dev#4105)
  feat!: Refactor `Badge` Control to a Dataclass; create new `Control.badge` property (flet-dev#4077)
  fix: clicking on `CupertinoContextMenuAction` doesn't close context menu (flet-dev#3948)
  fix dropdown `max_menu_height` (flet-dev#3974)
  Fix undefined name "Future" --> asyncio.Future (flet-dev#4230)
  wrap ListTile in material widget (flet-dev#4206)
  Update CONTRIBUTING.md (flet-dev#4208)
  TextField: suffix_icon, prefix_icon and icon can be Control or str (flet-dev#4173)
  feat!: enhance `Map` control (flet-dev#3994)
  skip running flutter doctor on windows if no_rich_output is True (flet-dev#4108)
  add --pyinstaller-build-args to pack cli command (flet-dev#4187)
  fix/feat: make `SearchBar`'s view height adjustable; add new properties (flet-dev#4039)
  fix: prevent button `style` from being modified in `before_update()` (flet-dev#4181)
  fix: disabling filled buttons is not visually respected (flet-dev#4090)
  when `label` is set, use `MainAxisSize.min` for the `Row` (flet-dev#3998)
  fix: `NavigationBarDestination.disabled` has no visual effect (flet-dev#4073)
  fix autofill in CupertinoTextField (flet-dev#4103)
  Linechart: jsonDecode tooltip before displaying (flet-dev#4069)
  fixed bgcolor, color and elevation (flet-dev#4126)
  ...
@ndonkoHenri
Copy link
Contributor

@sourcery-ai review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small bug with TextField: bad behaviour with suffix/prefix properties.
3 participants