-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to close search on mobile #26
Comments
Thanks for reporting this. I'll look into supporting mobile devices with the search as soon as possible. Overall, mobile support is a topic that needs a lot of improvement in the near future. Since, only a couple of days ago, this started as an internal project without any consideration on responsiveness, etc. (since internally, we only use it on Desktop), we didn't even think about search on mobile devices, to be honest (having it work "as good" as it does now is just a side-effect of using some semi-random CSS framework in the proof of concept stage 😅 ). I wasn't able to replicate the search bar opening arbitrarily in a desktop browser (with mobile device emulation), but we'll definitely look into it (while personally, I don't own an iPhone, I think I know someone who might be able to debug this with me). Again: Thanks for pointing this out, we're going to look into it 🙂 |
I believe the issue is Safari's missing support for the |
1. Use custom dialog implementation to increase compatibility since, for now, the <dialog> element doesn't provide the compatibility we need 2. Revamp file structure to make long files shorter and more readable Refs: fliegwerk/fliegdoc#26
1. Use custom dialog implementation to increase compatibility since, for now, the <dialog> element doesn't provide the compatibility we need 2. Revamp file structure to make long files shorter and more readable Refs: fliegwerk/fliegdoc#26 Closes: fliegwerk/fliegdoc#26
…due to incompatibility v2 uses its own implementation of dialogs which increases cross-browser compatibility. Unfortunately, it's incompatible with `scroll-behavior: smooth` on some browsers (tested in Chrome, it's working in Firefox), meaning, for now, we lose smooth scrolling here. Refs: #26
Describe the bug
As titled, when loading the docs on mobile, as soon as I scroll down the search pops up in the middle of the screen and cannot be closed.
To Reproduce
Expected behavior
Search should only show up when clicking on a search icon.
Screenshots
Smartphone:
The text was updated successfully, but these errors were encountered: