refactor: Custom dialogs and file structure #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Use custom dialog implementation to increase compatibility since, for now, the <dialog> element doesn't provide the compatibility we need 2. Revamp file structure to make long files shorter and more readable Refs: fliegwerk/fliegdoc#26
pklaschka
added
🐛 bug
# Conflicts: # package-lock.json # package.json
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 201f249 and detected 0 issues on this pull request. View more on Code Climate. |
fussel178
requested changes
Jan 23, 2021
There was a problem hiding this comment.
Have tested it with the current build of fliegdoc.
On desktop it works fine but in iOS it works on the main page of the fliegdoc documentation but not on the module pages (or "subpages"). (see attached video file)
It that a bug in fliegdoc or in the search-popup? 🤔
(tested with an iPhone 11)
Update
Nevermind, my fault. I forgot to replace the bundle.js in the subpage 😛.
IMG_0005.mp4
fussel178
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<dialog>element doesn't provide the compatibility we needCloses fliegwerk/fliegdoc#26