-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFC: Auto-run reading scripts #1322
Conversation
Build artifacts for commit
|
Build artifacts for commit |
Now that #1313 has been merged, the MF Ultralight reading fail state can be triggered. Known bugs:
|
3 bugs fixed, nearing final review state. New todo:
New build file coming once I get some of that done. In the mean time, here's a video demo of the changes: 1655849094_qFlipper.mp4 |
Build artifacts for commit |
Added a new |
I'm opening this for review, although I don't expect/recommend a merge. I know there's some work left to do, but I'd like a review from the team before continuing on. |
Hello @djsime1! You did wonderful work, but we can't merge your PR... |
I'll revise and re-open once these changes have been implemented if this PR isn't made obsolete. |
What's new
Todo
Notes
This PR is meant to be a proof of concept for aforementioned changes. I'd like to know if automatically running reading scripts with the universal read option is better or worse than what happens currently. My motivation is that I've seen various posts of confused users who didn't realize to fully read a card they had to run the corresponding script.
I'd like some people to flash this and provide feedback whether or not these changes improve the flow of NFC scenes.
Verification
Checklist (For Reviewer)