Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfc: Capture and display PWD_AUTH for NTAGs #1471

Closed
wants to merge 9 commits into from

Conversation

GMMan
Copy link
Contributor

@GMMan GMMan commented Jul 27, 2022

What's new

  • Reader authentication attempts on emulated NTAGs will now display the password in a log in a similar way to UID emulation logs.

Implementation notes:

  • PWD_AUTH event needs to pass additional information to event handler, and to avoid massive refactoring, I just added it as an additional field with a getter to nfc_worker that's only valid during the event callback. IMO it's pretty ugly, if you'd like me to refactor the callback to add an additional parameter, I can do that. Alternatively I could change the event type enum parameter to a struct pointer.
  • Scene state only stores a single integer and is limiting, and I don't want to add a stuct into nfc just for MFUL emulate scene, so there's a bit of a crazy flags system trying to stuff multiple state variables into the int.

Verification

  • Add manually or load any NTAG that supports password auth, emulate it, and read using NXP NFC TagInfo on Android on the full scan tab. A few seconds after reading, a log button should show up, and pressing the OK button should show a log that displays the password attempted (typically FF FF FF FF).

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added NFC NFC-related UI Affects UI New Feature Contains an IMPLEMENTATION of a new feature labels Jul 28, 2022
@djsime1 djsime1 mentioned this pull request Jul 29, 2022
3 tasks
@GMMan GMMan force-pushed the ntag-pwd-capture-rework branch from d5aad9d to a1af295 Compare August 8, 2022 21:19
@gornekich
Copy link
Member

Hello @GMMan !
It wasn't clear from Discord conversation. Do you want to continue work with auto reader auth capture in this PR?
Please, let me know if you continue here. You can mark this PR as Draft and switch to Ready for review after you finish

@GMMan
Copy link
Contributor Author

GMMan commented Aug 10, 2022

I'm leaving this PR as-is, new flow stuff will be in a different PR.

@gornekich
Copy link
Member

gornekich commented Aug 20, 2022

@GMMan I am still thinking about this PR. I am working on a module which will parse tag-reader communication in different thread and NFC application can display it on screen. I think I will add this functionality differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature Contains an IMPLEMENTATION of a new feature NFC NFC-related UI Affects UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants