Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Small visual tweaks #2394

Merged
merged 8 commits into from
Nov 14, 2023
Merged

chore: Small visual tweaks #2394

merged 8 commits into from
Nov 14, 2023

Conversation

markphelps
Copy link
Collaborator

Minor visual tweaks before release. IDK why this keeps showing old commits btw

Flag Form

Before

CleanShot 2023-11-14 at 09 35 00@2x

After

CleanShot 2023-11-14 at 09 34 47

Now shows a description of the different flag types. Mimics how segment form looks.

Token Created Modal

Now shows lock icon instead of check icon, as we have another check icon when you click copy the token to clipboard button

Before

CleanShot 2023-11-14 at 09 37 32

After

CleanShot 2023-11-14 at 09 38 26

* 'main' of https://github.com/flipt-io/flipt:
  chore(deps): bump golang.org/x/tools from 0.14.0 to 0.15.0 in /_tools (#2375)
* 'main' of https://github.com/flipt-io/flipt:
  chore(deps): bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc (#2370)
* 'main' of https://github.com/flipt-io/flipt:
  fix(cors): support fern and customizable allowed headers (#2393)
  feat: Oci icon readonly (#2391)
@markphelps markphelps requested a review from a team as a code owner November 14, 2023 14:43
Copy link
Contributor

github-actions bot commented Nov 14, 2023

Uffizzi Preview deployment-40717 was deleted.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6b83dd) 70.82% compared to head (0b6101e) 70.56%.

❗ Current head 0b6101e differs from pull request most recent head 6334bd5. Consider uploading reports for the commit 6334bd5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
- Coverage   70.82%   70.56%   -0.27%     
==========================================
  Files          81       81              
  Lines        8103     8011      -92     
==========================================
- Hits         5739     5653      -86     
+ Misses       2018     2013       -5     
+ Partials      346      345       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps enabled auto-merge (squash) November 14, 2023 15:50
@markphelps markphelps merged commit f6912e1 into main Nov 14, 2023
30 checks passed
@markphelps markphelps deleted the small-visual-tweaks branch November 14, 2023 16:04
markphelps added a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants