Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support import export namespace data #3356

Merged
merged 13 commits into from
Aug 6, 2024

Conversation

markphelps
Copy link
Collaborator

Allow importing/exporting namespace as object which includes name and description

markphelps and others added 8 commits August 5, 2024 14:20
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
….com/flipt-io/flipt into support-import-export-namespace-data

* 'support-import-export-namespace-data' of https://github.com/flipt-io/flipt:
  chore(deps): bump golang.org/x/sync from 0.7.0 to 0.8.0 (#3347)
  chore(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp (#3349)
  chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (#3346)
  chore(deps): bump github.com/coreos/go-oidc/v3 from 3.10.0 to 3.11.0 (#3345)
  chore(deps): bump go.opentelemetry.io/otel/exporters/zipkin (#3348)
  docs: add radekska as a contributor for code (#3355)
  feat: support postgresql url prefix (#3354)
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
@markphelps markphelps marked this pull request as ready for review August 6, 2024 13:52
@markphelps markphelps requested a review from a team as a code owner August 6, 2024 13:52
@markphelps markphelps added the needs docs Requires documentation updates label Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 77.39726% with 33 lines in your changes missing coverage. Please review.

Project coverage is 64.44%. Comparing base (776fca8) to head (52a5373).

Files Patch % Lines
internal/ext/common.go 73.07% 13 Missing and 1 partial ⚠️
internal/ext/importer.go 50.00% 14 Missing ⚠️
internal/oci/file.go 57.14% 1 Missing and 2 partials ⚠️
internal/ext/exporter.go 92.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3356      +/-   ##
==========================================
+ Coverage   64.40%   64.44%   +0.04%     
==========================================
  Files         172      172              
  Lines       13722    13820      +98     
==========================================
+ Hits         8837     8906      +69     
- Misses       4207     4232      +25     
- Partials      678      682       +4     
Flag Coverage Δ
unittests 64.44% <77.39%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
build/testing/integration.go Outdated Show resolved Hide resolved
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work @markphelps

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Aug 6, 2024
@kodiakhq kodiakhq bot merged commit 87ca6e8 into main Aug 6, 2024
59 checks passed
@kodiakhq kodiakhq bot deleted the support-import-export-namespace-data branch August 6, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs needs docs Requires documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants