Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

options, set.seed, and on.exit may have global side effects! #934

Merged
merged 5 commits into from
Aug 30, 2024
Merged

options, set.seed, and on.exit may have global side effects! #934

merged 5 commits into from
Aug 30, 2024

Conversation

EagleoutIce
Copy link
Member

No description provided.

@EagleoutIce EagleoutIce linked an issue Aug 30, 2024 that may be closed by this pull request
Recognize set.seed() as a side effect #930
Closed
@EagleoutIce EagleoutIce merged commit ee27161 into main Aug 30, 2024
15 checks passed
@EagleoutIce EagleoutIce deleted the 930-recognize-setseed-as-a-side-effect branch August 30, 2024 14:05
@EagleoutIce
Copy link
Member Author

This pull request is included in v2.0.17 (see Release v2.0.17 (Forcing Arguments, Improved Side-Effect Detection, and Lineage Command)).

LukasPietzschmann pushed a commit that referenced this pull request Sep 12, 2024
@EagleoutIce @LukasPietzschmann
options, set.seed, and on.exit may have global side effects! (#934
fedf248 
)

* feat: support `set.seed`

* feat: recognize options as side effect as well

* feat: support `on.exit` (closes #931)

* feat: supporting `sys.on.exit`

* lint-fix: handle linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recognize set.seed() as a side effect
1 participant
@EagleoutIce