options, set.seed, and on.exit may have global side effects! (#934

)

* feat: support `set.seed`

* feat: recognize options as side effect as well

* feat: support `on.exit` (closes #931)

* feat: supporting `sys.on.exit`

* lint-fix: handle linter errors

src/dataflow/environments/built-in.ts

@@ -174,7 +174,7 @@ registerSimpleFunctions(
 registerBuiltInFunctions(true,  ['apply', 'lapply', 'sapply', 'tapply', 'mapply'], defaultBuiltInProcessor,   { forceArgs: [false, true] }                                                 )
 registerBuiltInFunctions(true,  ['print'],                                         defaultBuiltInProcessor,   { returnsNthArgument: 0, forceArgs: 'all' as const }                         )
 registerBuiltInFunctions(true,  ['('],                                             defaultBuiltInProcessor,   { returnsNthArgument: 0 }                                                    )
-registerBuiltInFunctions(true,  ['load', 'load_all', 'setwd'],                     defaultBuiltInProcessor,   { hasUnknownSideEffects: true, forceArgs: [true] }                           )
+registerBuiltInFunctions(true,  ['load', 'load_all', 'setwd', 'set.seed'],         defaultBuiltInProcessor,   { hasUnknownSideEffects: true, forceArgs: [true] }                           )
 registerBuiltInFunctions(false, ['cat'],                                           defaultBuiltInProcessor,   { forceArgs: 'all' as const }                                                ) /* returns null */
 registerBuiltInFunctions(false, ['switch'],                                        defaultBuiltInProcessor,   {}                                                                           ) /* returns null */
 registerBuiltInFunctions(true,  ['return'],                                        defaultBuiltInProcessor,   { returnsNthArgument: 0, cfg: ExitPointType.Return }                         )
@@ -201,6 +201,8 @@ registerBuiltInFunctions(true,  ['quote', 'substitute', 'bquote'],
 registerBuiltInFunctions(true,  ['for'],                                           processForLoop,            {}                                                                           )
 registerBuiltInFunctions(true,  ['repeat'],                                        processRepeatLoop,         {}                                                                           )
 registerBuiltInFunctions(true,  ['while'],                                         processWhileLoop,          {}                                                                           )
+registerBuiltInFunctions(true,  ['options'],                                       defaultBuiltInProcessor,   { hasUnknownSideEffects: true, forceArgs: 'all' as const }                   )
+registerBuiltInFunctions(true,  ['on.exit', 'sys.on.exit'],                        defaultBuiltInProcessor,   { hasUnknownSideEffects: true }                                              )
 
 /* they are all mapped to `<-` but we separate super assignments */
 registerReplacementFunctions({ makeMaybe: true },  ['<-', '<<-'], '[', '[[', '$', '@', 'names', 'dimnames', 'attributes', 'attr', 'class', 'levels', 'rownames', 'colnames')

test/functionality/slicing/static-program-slices/calls-tests.ts

@@ -664,6 +664,23 @@ x`)
 		'setwd("f/")\nx', ['2@x'],
 		'setwd("f/")\nx'
 		)
-
+		assertSliced(label('Setting a fixed seed', [
+			'functions-with-global-side-effects', 'name-normal', 'numbers', 'call-normal', 'unnamed-arguments', 'newlines'
+		]), shell,
+		'seed <- 1234\nset.seed(seed)\nx', ['3@x'],
+		'seed <- 1234\nset.seed(seed)\nx'
+		)
+		assertSliced(label('Configuring options', [
+			'functions-with-global-side-effects', 'name-normal', 'numbers', 'call-normal', 'unnamed-arguments', 'newlines', 'named-arguments'
+		]), shell,
+		'options(y=2)\nx', ['2@x'],
+		'options(y=2)\nx'
+		)
+		assertSliced(label('Exit hooks', [
+			'functions-with-global-side-effects', 'name-normal', 'numbers', 'call-normal', 'unnamed-arguments', 'newlines', 'named-arguments', 'implicit-return', 'function-definitions'
+		]), shell,
+		'x\non.exit(function() 3)', ['1@x'],
+		'x\non.exit(function() 3)'
+		)
 	})
 }))