Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add location tracking mode #21

Merged
merged 4 commits into from
Feb 8, 2019
Merged

Add location tracking mode #21

merged 4 commits into from
Feb 8, 2019

Conversation

yoavrofe
Copy link
Collaborator

@yoavrofe yoavrofe commented Feb 6, 2019

Added myLocationTrackingMode with the following options: None, Tracking, TrackingCompass, TrackingGPS.

A callback named onCameraTrackingDismissed is called if the tracking mode is dismissed due to dragging of the map, etc.

Added a stub (not working yet) property myLocationVerticalAlignment for setting the location position, similar to what is done in React Native plugin.

@yoavrofe yoavrofe changed the title Click style and location Add location tracking mode Feb 6, 2019
@yoavrofe yoavrofe mentioned this pull request Feb 6, 2019
Closed
@yoavrofe yoavrofe requested a review from tobrun February 7, 2019 05:42
tobrun
tobrun reviewed Feb 7, 2019
View reviewed changes
android/src/main/java/com/mapbox/mapboxgl/MapboxMapBuilder.java Outdated Show resolved Hide resolved
android/src/main/java/com/mapbox/mapboxgl/Convert.java Outdated Show resolved Hide resolved
android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java Outdated Show resolved Hide resolved
android/src/main/java/com/mapbox/mapboxgl/MapboxMapController.java Outdated Show resolved Hide resolved
android/src/main/java/com/mapbox/mapboxgl/MapboxMapOptionsSink.java Outdated

void setMyLocationTrackingMode(int myLocationTrackingMode);

void setMyLocationVerticalAlignment(int myLocationVerticalAlignment);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not actionable atm but we might need to look into either using enums or using @StringDef/@IntDef for type safety

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's on the Java side, I thought it's enough to rely on this array.

example/ios/Runner.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
example/ios/Runner.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings Outdated Show resolved Hide resolved
@yoavrofe
Copy link
Collaborator Author

yoavrofe commented Feb 7, 2019

Thanks for your comments, @tobrun ! I love learning from you.

@yoavrofe yoavrofe mentioned this pull request Feb 7, 2019
Closed
@yoavrofe yoavrofe merged commit fada7f2 into master Feb 8, 2019
@yoavrofe yoavrofe deleted the click_style_and_location branch February 10, 2019 09:14
SheaSmith pushed a commit to SheaSmith/flutter-mapbox-gl that referenced this pull request Sep 15, 2019
@yoavrofe
Merge pull request flutter-mapbox-gl#21 from tobrun/click_style_and_l…
78db9e9 
…ocation

Add location tracking mode
@tobrun tobrun mentioned this pull request Feb 2, 2019
Closed
@GULERTOLGA GULERTOLGA mentioned this pull request Jul 13, 2020
Closed
@AliAkberAakash AliAkberAakash mentioned this pull request Apr 5, 2021
Closed
@MarkHarcosHUN MarkHarcosHUN mentioned this pull request Aug 1, 2022
Closed
@milad-alsabbagh milad-alsabbagh mentioned this pull request Apr 12, 2023
Closed
@Diielle Diielle mentioned this pull request Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoavrofe @tobrun