Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera update #22

Closed
wants to merge 7 commits into from
Closed

Camera update #22

wants to merge 7 commits into from

Conversation

yoavrofe
Copy link
Collaborator

@yoavrofe yoavrofe commented Feb 7, 2019

Add bearingTo and TiltTo to cameraUpdate.

@yoavrofe yoavrofe requested a review from tobrun February 7, 2019 18:52
@yoavrofe
Copy link
Collaborator Author

yoavrofe commented Feb 7, 2019

Turns out this commit includes the changes in #21 , so let's deal with #21 first.

@tobrun tobrun added this to the 0.0.2 milestone Feb 8, 2019
@yoavrofe
Copy link
Collaborator Author

yoavrofe commented Feb 8, 2019

After merging #21 this still shows all the changes, including the ones in #21 . Should I create a new pull request?

@yoavrofe
Copy link
Collaborator Author

yoavrofe commented Feb 8, 2019

I'll just close this pull request and create a new one.

@yoavrofe yoavrofe closed this Feb 8, 2019
@tobrun tobrun mentioned this pull request Feb 2, 2019
Closed
@GULERTOLGA GULERTOLGA mentioned this pull request Jul 13, 2020
Closed
@AliAkberAakash AliAkberAakash mentioned this pull request Apr 5, 2021
Closed
@MarkHarcosHUN MarkHarcosHUN mentioned this pull request Aug 1, 2022
Closed
@milad-alsabbagh milad-alsabbagh mentioned this pull request Apr 12, 2023
Closed
@Diielle Diielle mentioned this pull request Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobrun tobrun Awaiting requested review from tobrun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@yoavrofe @tobrun