Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flutter_tizen_texture_registrar unittest #141

Merged
merged 3 commits into from
Jul 15, 2021
Merged

Add flutter_tizen_texture_registrar unittest #141

merged 3 commits into from
Jul 15, 2021

Conversation

bwikbs
Copy link
Member

@bwikbs bwikbs commented Jul 12, 2021 •
edited
Loading

Contains follow things:

  • TC is taken from window's TC(flutter/shell/platform/windows/flutter_windows_texture_registrar_unittests.cc).
  • Add stub related to external texture

@bwikbs
Copy link
Member Author

bwikbs commented Jul 13, 2021

@WonyoungChoi I habitually amend the contents of review. 😢
Plz, re-check it.

@bwikbs
Add flutter_tizen_texture_registrar unittest
b4dafee 
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs
Apply review's comment
438a819 
* Remove redundant code

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim
swift-kim reviewed Jul 14, 2021
View reviewed changes
Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You understand you're still trying to test an unimplemented class, right?

shell/platform/tizen/testing/engine_modifier.h Outdated Show resolved Hide resolved
shell/platform/tizen/external_texture_pixel_gl_stub.cc Outdated Show resolved Hide resolved
shell/platform/tizen/external_texture_pixel_gl_stub.cc
}

bool ExternalTexturePixelGL::CopyPixelBuffer(size_t& width, size_t& height) {
if (texture_callback_ && user_data_) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user_data_ could be null I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right!
To be honest, this is a trick to avoid build errors. 😢

shell/platform/tizen/external_texture_surface_gl_stub.cc Outdated Show resolved Hide resolved
@bwikbs
Copy link
Member Author

bwikbs commented Jul 14, 2021

You understand you're still trying to test an unimplemented class, right?

I guess this TC tests the functionality of the texture registrar NOT texture. so I don't get your point..

@swift-kim
Copy link
Member

Oh, if that's the case, I got it.

@bwikbs
Apply review's comment #2
bd2df79 
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bbrto21 bbrto21 merged commit 322e67b into flutter-tizen:flutter-2.2.1-tizen Jul 15, 2021
@swift-kim swift-kim mentioned this pull request Aug 3, 2021
Merged
swift-kim pushed a commit that referenced this pull request Sep 27, 2021
@bwikbs @swift-kim
Add flutter_tizen_texture_registrar unittest (#141)
79a8c14 
* Add flutter_tizen_texture_registrar unittest

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Apply review's comment

* Remove redundant code

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Apply review's comment #2

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Nov 14, 2021
@bwikbs @swift-kim
Add flutter_tizen_texture_registrar unittest (#141)
be1f1bf 
* Add flutter_tizen_texture_registrar unittest

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Apply review's comment

* Remove redundant code

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Apply review's comment #2

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Dec 9, 2021
@bwikbs @swift-kim
Add flutter_tizen_texture_registrar unittest (#141)
2b871f4 
* Add flutter_tizen_texture_registrar unittest

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Apply review's comment

* Remove redundant code

Signed-off-by: MuHong Byun <mh.byun@samsung.com>

* Apply review's comment #2

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Dec 17, 2021
@bwikbs @swift-kim
Add flutter_tizen_texture_registrar unittest (#141)
01de1c3 
* Add flutter_tizen_texture_registrar unittest

* Apply review's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Feb 7, 2022
@bwikbs @swift-kim
Add flutter_tizen_texture_registrar unittest (#141)
b21b4f5 
* Add flutter_tizen_texture_registrar unittest

* Apply review's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Feb 11, 2022
@bwikbs @swift-kim
Add flutter_tizen_texture_registrar unittest (#141)
96cf698 
* Add flutter_tizen_texture_registrar unittest

* Apply review's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request May 12, 2022
@bwikbs @swift-kim
Add flutter_tizen_texture_registrar unittest (#141)
2cf690f 
* Add flutter_tizen_texture_registrar unittest

* Apply review's comment

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Aug 5, 2022
@bwikbs @swift-kim
Add flutter_tizen_texture_registrar unittest (#141)
83bf65d 
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
@chinmaygarde @dnfield
Add an OpenGL ES stub and parameterize all playgrounds on rendering b…
3b1dfc4 
…ackend. (#141)

As we add more rendering backends, adding a new enum value to a single macro
`INSTANTIATE_PLAYGROUND_SUITE` in `playground.h` will create a new test variant
in any suite that uses playgrounds.

The invocations will look like the following:

```
[ RUN      ] Play/TypographerTest.CanCreateGlyphAtlas/Metal
[       OK ] Play/TypographerTest.CanCreateGlyphAtlas/Metal (210 ms)
[ RUN      ] Play/TypographerTest.CanCreateGlyphAtlas/OpenGLES
[       OK ] Play/TypographerTest.CanCreateGlyphAtlas/OpenGLES (xxx ms)
```

If you want to test just one backend, you may add a filter like so
`--gtest_filter="*/Metal"`

Right now, I have not added a the OpenGLES variant to the default test suite
instantiation since there are so many failures (that is just a stub ATM). But,
if the need arises to skip specific tests based on the backend in use (we won't
support instancing in OpenGLES for example), the backend for the playground may
be queried before deciding to GTEST_SKIP the invocation.

One additional change in the patch that will be reworked soon is the Metal
specificity of the source set generated after reflection. This will be made
agnostic in the coming few patches. Right now, these headers are in the `mtl`
folder.
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
@bwikbs @swift-kim
Add flutter_tizen_texture_registrar unittest (#141)
a9bda4c 
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WonyoungChoi WonyoungChoi WonyoungChoi left review comments

@swift-kim swift-kim swift-kim left review comments

@bbrto21 bbrto21 bbrto21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bwikbs @swift-kim @WonyoungChoi @bbrto21