forked from flutter/engine
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ExternalTexture stub files #164
Merged
swift-kim
merged 2 commits into
flutter-tizen:flutter-2.2.1-tizen
from
swift-kim:remove-texture-stubs
Aug 4, 2021
Merged
Remove ExternalTexture stub files #164
swift-kim
merged 2 commits into
flutter-tizen:flutter-2.2.1-tizen
from
swift-kim:remove-texture-stubs
Aug 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bbrto21
approved these changes
Aug 4, 2021
swift-kim
force-pushed
the
remove-texture-stubs
branch
from
August 4, 2021 06:08
3fd69c4
to
5edd083
Compare
I updated as requested by @bwikbs. |
bwikbs
reviewed
Aug 4, 2021
@@ -2,7 +2,12 @@ | |||
// Use of this source code is governed by a BSD-style license that can be | |||
// found in the LICENSE file. | |||
|
|||
#pragma clang diagnostic push | |||
#pragma clang diagnostic ignored "-Wunused-private-field" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ This is what I am looking for!
bwikbs
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It's perfect to me! 😄
swift-kim
force-pushed
the
remove-texture-stubs
branch
from
August 4, 2021 06:19
5edd083
to
6afcb6a
Compare
swift-kim
added a commit
that referenced
this pull request
Sep 27, 2021
* Remove ExternalTexture stub files * Create a dummy external_texture_surface_gl_linux.cc
swift-kim
added a commit
that referenced
this pull request
Nov 14, 2021
* Remove ExternalTexture stub files * Create a dummy external_texture_surface_gl_linux.cc
swift-kim
added a commit
that referenced
this pull request
Dec 9, 2021
* Remove ExternalTexture stub files * Create a dummy external_texture_surface_gl_linux.cc
swift-kim
added a commit
that referenced
this pull request
Dec 17, 2021
* Remove ExternalTexture stub files * Create a dummy external_texture_surface_gl_linux.cc
swift-kim
added a commit
that referenced
this pull request
Feb 7, 2022
* Remove ExternalTexture stub files * Create a dummy external_texture_surface_gl_linux.cc
swift-kim
added a commit
that referenced
this pull request
Feb 11, 2022
* Remove ExternalTexture stub files * Create a dummy external_texture_surface_gl_linux.cc
swift-kim
added a commit
that referenced
this pull request
May 12, 2022
* Remove ExternalTexture stub files * Create a dummy external_texture_surface_gl_linux.cc
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
* Remove ExternalTexture stub files * Create a dummy external_texture_surface_gl_linux.cc
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
* Remove ExternalTexture stub files * Create a dummy external_texture_surface_gl_linux.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_stub.cc
files which were originally added by Add flutter_tizen_texture_registrar unittest #141. This doesn't affect existing unit tests.#include <Evas_GL_GLES3_Helpers.h>
with#include "tizen_evas_gl_helper.h"
.