-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flutter Windows API v2 prototype for review [do not submit] #18112
Conversation
Seeing this in concrete terms, I'm pretty concerned by the amount of code that's moving from the embedding to the runner (we we lose all control over it). E.g., the unicode input handling fixes I made recently would be impossible here, because those bugs would have been baked into everyone's existing runners. I think we'll need to seriously consider having multiple libraries (one for Win32, one for CoreWindow). I need to think about that some more though, as it has a lot of potential implications. |
@stuartmorgan based on the above feedback I've
Although this approach has different tradeoffs, I agree it feels more encapsulated and cleaner. |
Based on feedback, this approach is being abandoned in favor of Refactor Win32FlutterWindow in preparation for UWP windowing implementation #18878 hence closing |
[NOTE: This PR is to solicit feedback on the shape of the API and changes to Client Wrapper, it will likely be abandoned in favor of a staged set of changes.]
Prototype of an update to the Windows API and shell implementation to remove the dependency on user32.dll and friends in order to enable alternative Windows host environments and runners to be supported.
At a high level this change:
Remaining work needed to land:
Update