Refactor Win32FlutterWindow in preparation for UWP windowing implementation #18878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
10 tasks
clarkezone
force-pushed
the
refactorwin32flutterwindow
branch
2 times, most recently
from
a6a57c0 to
04a4681
Compare
Switch input handling infra to FlutterWindowsView win32_flutter_window implement WindowBindingHandler Strip unneeded functionality from win32flutterwindow Fulfill WindowBindingHandler interface in Win32FlutterWindow Add implementations for missing input handling in Win32FlutterWindow Cleanup dead code Correctly hook up rendering again Fix resizing clang-format Fix clipboard Cleanup Rename Add comments cleanup
clarkezone
force-pushed
the
refactorwin32flutterwindow
branch
from
04a4681 to
ee29027
Compare
|
Ready for review. |
stuartmorgan
requested changes
Jun 23, 2020
|
All actionable feedback addressed, some questions in comments. |
|
All feedback addrsesed. |
|
Merged in latest master since there were a bunch of test failures on the last run (mostly non-Windows) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2020
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Jul 7, 2020
…tation (flutter#18878) * Add flutter_windows_view and window_binding_handler Switch input handling infra to FlutterWindowsView win32_flutter_window implement WindowBindingHandler Strip unneeded functionality from win32flutterwindow Fulfill WindowBindingHandler interface in Win32FlutterWindow Add implementations for missing input handling in Win32FlutterWindow Cleanup dead code Correctly hook up rendering again Fix resizing clang-format Fix clipboard Cleanup Rename Add comments cleanup * clang-format * CR Feedback * clang-format; gn format * Fix licensing * CR feedback * CR feedback * CR feedback * Git rid of unnecessar :: prefixes * Extract WindowBindingHandlerDelegate as an interface * Missing file * Extract physical window bounds as a struct * CR Feedback * CR feedback * clang-format Co-authored-by: Stuart Morgan <stuartmorgan@google.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2020
a-siva
added a commit
to a-siva/flutter
that referenced
this pull request
Jul 7, 2020
3fe5edf Roll Skia from cf5e35f72130 to b4d60f807dbd (5 revisions) (flutter/engine#19587) b919945 include list_libraries.dart as a snapshot for fuchsia (flutter/engine#19567) de0932b Manual roll of Dart 06cb010247...69aba23371 (flutter/engine#19577) 35b5aa5 switch const finder to package_config (flutter/engine#19576) 07d5090 Roll Skia from 0c0d8dd6d637 to cf5e35f72130 (13 revisions) (flutter/engine#19573) 0541502 kick build (flutter/engine#19575) a53782f Roll Skia from 6130d5079d55 to 0c0d8dd6d637 (3 revisions) (flutter/engine#19570) d0d6a4c Refactor Win32FlutterWindow in preparation for UWP windowing implementation (flutter/engine#18878) 110a579 Track motion events for reuse post gesture disambiguation (flutter/engine#19484) 5f8e91c Resubmit frame when the surface is switched (flutter/engine#19555) ab0abdd Roll Fuchsia Linux SDK from TvWbh... to 1oAHN... (flutter/engine#19566)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2020
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract key parts of Win32FlutterWindow into a new class FlutterWindowsView that will act as a HWND/CoreWindow agnostic Windows view. Win32FlutterWindow communicates state changes to FlutterWindowsView via a new FlutterWindowBinding interface. Subsequent changes will introduce a UWPFlutterWindow and related machinery.
This approach supersedes Flutter Windows API v2 prototype for review [do not submit] #18112
Related Issues
Add support for Windows 10/UWP flutter/flutter#14967
Tests
Covered by existing collateral
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.