Track motion events for reuse post gesture disambiguation #19484
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -183,6 +187,7 @@ private void addPointerForIndex( | |||
|
|
|||
| long timeStamp = event.getEventTime() * 1000; // Convert from milliseconds to microseconds. | |||
|
|
|||
| packet.putLong(motionEventId.getId()); | |||
There was a problem hiding this comment.
do you know if the other embeddings have to be updated as well? I wonder if adding the field to the end is safer.
There was a problem hiding this comment.
no, this field will be set to 0 for other embeddings and nothing else needs to change.
| private static final AtomicLong ID_COUNTER = new AtomicLong(0); | ||
| private final long id; | ||
|
|
||
| private MotionEventId(long id) { |
There was a problem hiding this comment.
would this wrapper object provide something that just the return value of AtomicLong doesn't?
There was a problem hiding this comment.
not much really, except type safety. If you feel strongly about this, I can move to atomic long.
There was a problem hiding this comment.
Got it. I don't feel strongly about it, so your call!
| @Nullable | ||
| public MotionEvent pop(MotionEventId eventId) { | ||
| // TODO(kaushikiska) do the actual timestamp based book-keeping. | ||
| return eventById.remove(eventId); |
There was a problem hiding this comment.
do you plan to remove all the previous events as well? How would we make sure that the queue of gestures doesn't grow for ever?
For example:
If the motion events aren't owned by the Android view, how would we make sure that those are ignored or removed?
If there are N motion events, but only the last one is owned by the Android view, where would we delete the motion events owned by Flutter widgets?
There was a problem hiding this comment.
This class will now manage all the events encountered by the Flutter view. Given that all the platform view's events are managed by Flutter view as well, this will essentially only the events for Flutter view and its subviews.
Once we pop an event, I plan on popping all the events that occurred prior to the event and see how that looks like. If that causes drift, we might have to come up with an alternate pruning strategy (for example, periodically remove all the motion events that are more than say 3 seconds old(.
iskakaushik
force-pushed
the
android-track-motion-events
branch
2 times, most recently
from
27015c8 to
a9adee6
Compare
iskakaushik
changed the title
iskakaushik
force-pushed
the
android-track-motion-events
branch
from
a9adee6 to
a03b013
Compare
This change makes it so that we track all the motion events encountered by `FlutterView` and all of its subviews in the `MotionEventTracker` class, indexed by a unique `MotionEventId`. This identifier is then passed to the Flutter framework as seen in flutter/flutter#60930. Once the gestures take part in gesture disambiguation and are sent back to the engine, we look-up the original motion event using the `MotionEventId` and dispatch it to the platform. Bug: flutter/flutter#58837
iskakaushik
force-pushed
the
android-track-motion-events
branch
from
a03b013 to
2ff6ad8
Compare
) This change makes it so that we track all the motion events encountered by `FlutterView` and all of its subviews in the `MotionEventTracker` class, indexed by a unique `MotionEventId`. This identifier is then passed to the Flutter framework as seen in flutter/flutter#60930. Once the gestures take part in gesture disambiguation and are sent back to the engine, we look-up the original motion event using the `MotionEventId` and dispatch it to the platform. Bug: flutter/flutter#58837
3fe5edf Roll Skia from cf5e35f72130 to b4d60f807dbd (5 revisions) (flutter/engine#19587) b919945 include list_libraries.dart as a snapshot for fuchsia (flutter/engine#19567) de0932b Manual roll of Dart 06cb010247...69aba23371 (flutter/engine#19577) 35b5aa5 switch const finder to package_config (flutter/engine#19576) 07d5090 Roll Skia from 0c0d8dd6d637 to cf5e35f72130 (13 revisions) (flutter/engine#19573) 0541502 kick build (flutter/engine#19575) a53782f Roll Skia from 6130d5079d55 to 0c0d8dd6d637 (3 revisions) (flutter/engine#19570) d0d6a4c Refactor Win32FlutterWindow in preparation for UWP windowing implementation (flutter/engine#18878) 110a579 Track motion events for reuse post gesture disambiguation (flutter/engine#19484) 5f8e91c Resubmit frame when the surface is switched (flutter/engine#19555) ab0abdd Roll Fuchsia Linux SDK from TvWbh... to 1oAHN... (flutter/engine#19566)
|
(go/tested-engine-prs nag) |
This change makes it so that we track all the motion events encountered by
FlutterViewand all of its subviews in theMotionEventTrackerclass, indexed by a uniqueMotionEventId. This identifier is then passed to the Flutter framework as seen in flutter/flutter#60930. Once the gestures take part in gesture disambiguation and are sent back to the engine, we look-up the original motion event using theMotionEventIdand dispatch it to the platform.Bug: flutter/flutter#58837