Add windows plugin texture support

[jnschulze]

Description

This PR adds OpenGL texture support for plugins on the Windows platform.

Once this has landed flutter/flutter#61098 needs to be merged as well.

Related Issues

• Support Texture widget in Windows embedding flutter#38601
• Texture support for glfw. #9822

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the contributor guide and followed the process outlined there for submitting PRs.
• I signed the CLA.
• I read and followed the C++, Objective-C, Java style guides for the engine.
• I read the tree hygiene wiki page, which explains my responsibilities.
• I updated/added relevant documentation.
• All existing and new tests are passing.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

• No, no existing tests failed, so this is not a breaking change.
• Yes, this is a breaking change.

[jnschulze]

@stuartmorgan
@chinmaygarde

Could you review this PR please?

[cloudwebrtc]

@jnschulze I tested on the flutter-webrtc plugin for windows and it works. You did cool things.

[jnschulze]

@cloudwebrtc
I‘m glad it‘s working. But since this is based on your GLFW texture support PR (#9822) the credit goes to you.

[clarkezone]

Generally looks good. Will need to rebase on top of #18878 which will be landing first.

[clarkezone]

#18878 has landed now. Please update to reflect that, thx.

[jnschulze]

@clarkezone I've just updated the PR. Please have a look.

[clarkezone]

LGTM. Is there a demo / hello world example of how to work with external textures?

[jnschulze]

@stuartmorgan done, see #23623

[stuartmorgan]

Recipe change out for review: https://flutter-review.googlesource.com/c/recipes/+/9680

[escamoteur]

We are currently working on an FFI wrapper for the WebGPU API as a more flexible approach to OpenGL and till I stumbled upon this issue I wasn't aware that its currently not possbile to use a Widget with external Textturebuffer on Windows.
Is this already avalable on MacOs and Linux?

[stuartmorgan]

Is this already avalable on MacOs and Linux?

flutter/flutter#64188

[vjeson]

@vjeson

I can't get it to work, could you update your example demo? And it's better to how to use it in multithreading with a video player

I've just updated the demo and added a simple timer that periodically calls MarkTextureFrameAvailable to demonstrate that it can be called from arbitrary threads. See https://github.com/jnschulze/flutter-playground/blob/52005d38e6935c4bbafe07b7f6f5346ca7cc30de/windows_texture_test/windows/windows_texture_test_plugin.cpp#L166

Thanks for your demo,I still have another issue, I'm migrating flutter-webrtc for windows, it uses event_sink onFrame event.
void FlutterVideoRenderer::OnFrame(scoped_refptr frame) {
if (!first_frame_rendered) {
if (event_sink_) {
EncodableMap params;
params[EncodableValue("event")] = "didFirstFrameRendered";
params[EncodableValue("id")] = texture_id_;
//event_sink_->Success(EncodableValue(params));
}
Here I got a thread exception, we need to switch to UI thread to run event_sink_->Success .
Just as the doc official demo, I don't known how to call it on desktop embedding,It seems we didn't export such method for desktop embedding.
https://flutter.dev/docs/development/platform-integration/platform-channels#channels-and-platform-threading
Maybe we need to have a method like this ? task_runners_.GetPlatformTaskRunner()->RunsTasksOnCurrentThread()

[jnschulze]

https://flutter.dev/docs/development/platform-integration/platform-channels#channels-and-platform-threading
Maybe we need to have a method like this ? task_runners_.GetPlatformTaskRunner()->RunsTasksOnCurrentThread()

You're right. Unfortunately, the client wrapper doesn't expose a method like PostTask.

While it should be fairly simple to extend the client wrapper accordingly, we shouldn't discuss it here as it's a general Windows platform issue.

[escamoteur]

Is this already avalable on MacOs and Linux?

flutter/flutter#64188

So there isn't even an issue for MacOs?

[jnschulze]

Is this already avalable on MacOs and Linux?

flutter/flutter#64188

So there isn't even an issue for MacOs?

Only Linux is missing. macOS support was introduced by #8507

[stuartmorgan]

The handling of the new header has landed end-to-end, so this is good to land as soon as the tree re-opens 🎉

[dahabit]

@stuartmorgan Thank you for your support, I really appreciate it, this issue was blocking using for making cool Windows desktop apps with Flutter.

can't wait to see it land in the stable channel

[oddko]

What would it require for this to gain some zero-copy interop with an OpenGL texture/FBO (and/or other APIs) ? Adapted the provided example to have a texture backed by an OpenGL renderer and calls to glReadPixels are prohibitively expensive for any real time rendering (around 10ms for a 1920x1080 texture, if not more on lower end systems). Pixel buffers aren't suited for such use.

[stuartmorgan]

What would it require for this to gain some zero-copy interop with an OpenGL texture/FBO (and/or other APIs) ?

The first step would be a design doc with one or more concrete proposals for possible texture sources, including exploring what that API would look like, how it would work with Angle, and what the impact on that API of an eventual migration to a DirectX Skia backend would be.