Reland: Move asset opening to background thread, fix dart persistent value destruction #40183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne into move_decompress_to_io
chinmaygarde
approved these changes
Mar 9, 2023
| if (!dart_state) { | ||
| return; | ||
| } | ||
| tonic::DartState::Scope scope(dart_state); | ||
|
|
||
| std::unique_ptr<tonic::DartPersistentValue> buffer_handle( |
There was a problem hiding this comment.
Looked into this, and it's actually ok to destruct the tonic::DartPersistentValue outside of a DartState::Scope. The DartPersistentValue holds a weak reference to the DartState used during construction and will enter that DartState's scope to delete the wrapped value.
So these unique_ptrs should be moved to the top of the function in order to ensure that they are not leaked if it returns early.
jason-simmons
approved these changes
Mar 9, 2023
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 10, 2023
…ersistent value destruction (flutter/engine#40183)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 10, 2023
…ersistent value destruction (flutter/engine#40183)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #39918 but with the fixes suggested by @jason-simmons from #40147