Handle a11y focus event on Ios and android #41777

hannah-hyj · 2023-05-05T17:17:21Z

framework change:flutter/flutter#126171
issue: flutter/flutter#94523

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

shell/platform/android/io/flutter/embedding/engine/systemchannels/AccessibilityChannel.java

shell/platform/android/io/flutter/view/AccessibilityBridge.java

...atform/android/test/io/flutter/embedding/engine/systemchannels/AccessibilityChannelTest.java

shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm

flutter-dashboard · 2023-05-11T17:14:05Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #41777 at sha f95041f

...atform/android/test/io/flutter/embedding/engine/systemchannels/AccessibilityChannelTest.java

shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm

chunhtai

LGTM

chunhtai · 2023-05-16T22:13:18Z

shell/platform/android/test/io/flutter/view/AccessibilityBridgeTest.java

+        ArgumentCaptor.forClass(AccessibilityEvent.class);
+    verify(mockParent).requestSendAccessibilityEvent(eq(mockRootView), eventCaptor.capture());
+    AccessibilityEvent event = eventCaptor.getAllValues().get(0);
+    assertEquals(event.getEventType(), AccessibilityEvent.TYPE_VIEW_FOCUSED);


also check for id?

I agree with this!

I tested nodeId in AccessibilityChannelTest.java
And there is no public api to get id from AccessibilityEvent.

This seems to not be addressed yet

per our offline discussion we talked previously, we can create a mocked event spy on the setSource

chunhtai · 2023-05-16T22:15:24Z

added vashworth for ios and camsim99 for android

camsim99

Android part LGTM!

camsim99 · 2023-05-17T15:58:01Z

shell/platform/android/test/io/flutter/view/AccessibilityBridgeTest.java

+        ArgumentCaptor.forClass(AccessibilityEvent.class);
+    verify(mockParent).requestSendAccessibilityEvent(eq(mockRootView), eventCaptor.capture());
+    AccessibilityEvent event = eventCaptor.getAllValues().get(0);
+    assertEquals(event.getEventType(), AccessibilityEvent.TYPE_VIEW_FOCUSED);


I agree with this!

vashworth · 2023-05-17T18:33:09Z

shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm

@@ -362,6 +362,10 @@ static bool DidFlagChange(const flutter::SemanticsNode& oldNode,
    NSString* message = annotatedEvent[@"data"][@"message"];
    ios_delegate_->PostAccessibilityNotification(UIAccessibilityAnnouncementNotification, message);
  }
+  if ([type isEqualToString:@"focus"]) {
+    SemanticsObject* node = objects_.get()[annotatedEvent[@"nodeId"]];
+    ios_delegate_->PostAccessibilityNotification(UIAccessibilityLayoutChangedNotification, node);


What happens if node is nil? Seems like nil is an OK arg, but just double checking

Tested in my device, if node is nil, nothing will happen, the focus will not be changed

vashworth

LGTM

chinmaygarde · 2023-05-25T20:04:57Z

Are we blocked on this?

hellohuanlin · 2023-05-25T20:33:56Z

Nope. I think we can land it with @vashworth's stamp

…41777)

…127890) flutter/engine@a6d3124...1ba8091 2023-05-30 jhy03261997@gmail.com Handle a11y focus event on Ios and android (flutter/engine#41777) 2023-05-30 matej.knopp@gmail.com Fix unitialized SkRect (flutter/engine#42403) 2023-05-30 reidbaker@google.com Update engine testing to use api 33 for android tests. (flutter/engine#42351) 2023-05-30 gspencergoog@users.noreply.github.com Reland: "Adding app lifecycle notification for macOS and Linux, add `hidden` state." (#40542) (flutter/engine#42418) 2023-05-30 30870216+gaaclarke@users.noreply.github.com [Impeller] Fixed GlyphAtlasWithLotsOfdUniqueGlyphSize (flutter/engine#42423) 2023-05-30 54558023+keyonghan@users.noreply.github.com Remove legacy xcode properties/dependencies (flutter/engine#42368) 2023-05-30 skia-flutter-autoroll@skia.org Roll Skia from bab82f14da1a to fed417995ba9 (7 revisions) (flutter/engine#42424) 2023-05-30 30870216+gaaclarke@users.noreply.github.com [Impeller] removed vulkan unit test csv (flutter/engine#42354) 2023-05-30 skia-flutter-autoroll@skia.org Roll Skia from d22106cc40a0 to bab82f14da1a (7 revisions) (flutter/engine#42420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

issue: #94523 engine pr: flutter/engine#41777

flutter-dashboard bot added platform-android platform-ios labels May 5, 2023

This comment was marked as outdated.

Sign in to view

flutter-dashboard bot added the needs tests label May 5, 2023

cyanglaz marked this pull request as draft May 8, 2023 19:42

hannah-hyj mentioned this pull request May 8, 2023

Add a FocusSemanticEvent flutter/flutter#126171

Merged

8 tasks

hannah-hyj marked this pull request as ready for review May 9, 2023 20:27

hannah-hyj removed the needs tests label May 9, 2023

hannah-hyj changed the title ~~[draft] Handle a11y focus event~~ Handle a11y focus event on Ios and android May 9, 2023

hannah-hyj mentioned this pull request May 9, 2023

[Feature Request] API to explicitly set accessibility focus flutter/flutter#94523

Closed

hannah-hyj force-pushed the android-focus branch from e2df750 to 6f4893c Compare May 10, 2023 01:40

chunhtai self-requested a review May 10, 2023 15:38

chunhtai reviewed May 10, 2023

View reviewed changes

hannah-hyj force-pushed the android-focus branch from ad51c37 to 6751fd9 Compare May 11, 2023 02:27

flutter-dashboard bot added the will affect goldens label May 11, 2023

hannah-hyj requested a review from chunhtai May 11, 2023 18:26

chunhtai reviewed May 11, 2023

View reviewed changes

...atform/android/test/io/flutter/embedding/engine/systemchannels/AccessibilityChannelTest.java Show resolved Hide resolved

shell/platform/darwin/ios/framework/Source/accessibility_bridge.mm Outdated Show resolved Hide resolved

hannah-hyj requested a review from chunhtai May 12, 2023 22:23

chunhtai approved these changes May 16, 2023

View reviewed changes

chunhtai requested review from vashworth and camsim99 May 16, 2023 22:14

camsim99 approved these changes May 17, 2023

View reviewed changes

vashworth reviewed May 17, 2023

View reviewed changes

hannah-hyj requested a review from vashworth May 18, 2023 00:57

vashworth approved these changes May 18, 2023

View reviewed changes

leighajarett requested a review from hellohuanlin May 22, 2023 19:12

hannah-hyj added 21 commits May 30, 2023 13:40

Update AccessibilityBridgeTest.java

052e7fa

Update AccessibilityChannel.java

b9456ca

Update AccessibilityChannel.java

9da2c8c

Update AccessibilityBridgeTest.java

82cf3e2

Update AccessibilityBridgeTest.java

f3a3b27

Update AccessibilityBridgeTest.java

958c1af

Update AccessibilityBridgeTest.java

6a12f87

Update AccessibilityBridgeTest.java

a9167ba

Update AccessibilityBridgeTest.java

e0ab00a

Update AccessibilityBridgeTest.java

156ebca

Update AccessibilityBridgeTest.java

7f829e8

Update AccessibilityBridgeTest.java

f18b6e1

Update AccessibilityBridgeTest.java

423d556

Update AccessibilityBridgeTest.java

dd5191e

Update AccessibilityBridgeTest.java

3a8bb9e

update tests

242aeba

lint

73fb81a

test

751180d

update tests

bf97dba

lint

78a0708

Update AccessibilityBridge.java

8e85983

hannah-hyj force-pushed the android-focus branch from aabfa26 to 8e85983 Compare May 30, 2023 20:40

Update accessibility_bridge_test.mm

2e06b28

hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2023

auto-submit bot merged commit 1ba8091 into flutter:main May 30, 2023

engine-flutter-autoroll mentioned this pull request May 30, 2023

Roll Flutter Engine from a6d3124cedb5 to 1ba8091fbca7 (9 revisions) flutter/flutter#127890

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2023

1ba8091fb Handle a11y focus event on Ios and android (flutter/engine#…

1f80d62

…41777)

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 31, 2023

Add a FocusSemanticEvent (#126171)

a829b57

issue: #94523 engine pr: flutter/engine#41777

HansMuller mentioned this pull request Jun 2, 2023

Flutter Framework Team: Notable Commits flutter/flutter#121415

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle a11y focus event on Ios and android #41777

Handle a11y focus event on Ios and android #41777

hannah-hyj commented May 5, 2023 •

edited

Loading

This comment was marked as outdated.

flutter-dashboard bot commented May 11, 2023

chunhtai left a comment

chunhtai May 16, 2023

camsim99 May 17, 2023

hannah-hyj May 18, 2023

chunhtai May 25, 2023 •

edited

Loading

chunhtai commented May 16, 2023

camsim99 left a comment

camsim99 May 17, 2023

vashworth May 17, 2023

hannah-hyj May 18, 2023

vashworth left a comment

chinmaygarde commented May 25, 2023

hellohuanlin commented May 25, 2023

Handle a11y focus event on Ios and android #41777

Handle a11y focus event on Ios and android #41777

Conversation

hannah-hyj commented May 5, 2023 • edited Loading

Pre-launch Checklist

This comment was marked as outdated.

flutter-dashboard bot commented May 11, 2023

chunhtai left a comment

Choose a reason for hiding this comment

chunhtai May 16, 2023

Choose a reason for hiding this comment

camsim99 May 17, 2023

Choose a reason for hiding this comment

hannah-hyj May 18, 2023

Choose a reason for hiding this comment

chunhtai May 25, 2023 • edited Loading

Choose a reason for hiding this comment

chunhtai commented May 16, 2023

camsim99 left a comment

Choose a reason for hiding this comment

camsim99 May 17, 2023

Choose a reason for hiding this comment

vashworth May 17, 2023

Choose a reason for hiding this comment

hannah-hyj May 18, 2023

Choose a reason for hiding this comment

vashworth left a comment

Choose a reason for hiding this comment

chinmaygarde commented May 25, 2023

hellohuanlin commented May 25, 2023

hannah-hyj commented May 5, 2023 •

edited

Loading

chunhtai May 25, 2023 •

edited

Loading