Remove legacy xcode properties/dependencies #42368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusuf-goog
approved these changes
May 30, 2023
| @@ -54,7 +54,6 @@ platform_properties: | |||
| device_type: none | |||
| cpu: x86 | |||
| os: Mac-12 | |||
| xcode: 14e222b | |||
| $flutter/osx_sdk : >- | |||
| { | |||
| "sdk_version": "14e222b" | |||
There was a problem hiding this comment.
Do you need the runtime versions listed anywhere?
There was a problem hiding this comment.
No on the platform level. We have only one target needing runtimes. See Mac Unopt below.
keyonghan
added
the
autosubmit
14 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2023
…127890) flutter/engine@a6d3124...1ba8091 2023-05-30 jhy03261997@gmail.com Handle a11y focus event on Ios and android (flutter/engine#41777) 2023-05-30 matej.knopp@gmail.com Fix unitialized SkRect (flutter/engine#42403) 2023-05-30 reidbaker@google.com Update engine testing to use api 33 for android tests. (flutter/engine#42351) 2023-05-30 gspencergoog@users.noreply.github.com Reland: "Adding app lifecycle notification for macOS and Linux, add `hidden` state." (#40542) (flutter/engine#42418) 2023-05-30 30870216+gaaclarke@users.noreply.github.com [Impeller] Fixed GlyphAtlasWithLotsOfdUniqueGlyphSize (flutter/engine#42423) 2023-05-30 54558023+keyonghan@users.noreply.github.com Remove legacy xcode properties/dependencies (flutter/engine#42368) 2023-05-30 skia-flutter-autoroll@skia.org Roll Skia from bab82f14da1a to fed417995ba9 (7 revisions) (flutter/engine#42424) 2023-05-30 30870216+gaaclarke@users.noreply.github.com [Impeller] removed vulkan unit test csv (flutter/engine#42354) 2023-05-30 skia-flutter-autoroll@skia.org Roll Skia from d22106cc40a0 to bab82f14da1a (7 revisions) (flutter/engine#42420) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now only $flutter/osx_sdk property is being used, and it's safe to remove deprecated entries from ci.yaml.
Part of flutter/flutter#127534