[ci.yaml] Add xcode dependency #42488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
fluttergithubbot
approved these changes
Jun 1, 2023
dnfield
reviewed
Jun 1, 2023
.ci.yaml
Outdated
| @@ -49,7 +49,8 @@ platform_properties: | |||
| # CIPD flutter/java/openjdk/$platform | |||
| dependencies: >- | |||
| [ | |||
| {"dependency": "open_jdk", "version": "version:11"} | |||
| {"dependency": "open_jdk", "version": "version:11"}, | |||
| {"dependency": "xcode", "version": "14a5294e"} | |||
There was a problem hiding this comment.
Consider adding a comment about if/how this is related to line 58 below and whether both need to be updated if one changes.
|
I eagerly merged this into #42483. |
|
Scenario test is still failing, though. |
CaseyHillers
force-pushed
the
flutter-3.10-candidate.1
branch
from
f180133 to
e7d299b
Compare
dnfield
reviewed
Jun 1, 2023
dnfield
reviewed
Jun 1, 2023
CaseyHillers
added
the
autosubmit
FlutterSu
pushed a commit
to flutter-rosita/engine
that referenced
this pull request
Sep 14, 2023
FlutterSu
pushed a commit
to flutter-rosita/engine
that referenced
this pull request
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.