Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll Skia from 8c1e2bf9492c to 8054b098b5cd (5 revisions) #57197

Conversation

skia-flutter-autoroll
Copy link
Contributor

https://skia.googlesource.com/skia.git/+log/8c1e2bf9492c..8054b098b5cd

2024-12-13 kjlubick@google.com Update delaunator to read from GoB mirror
2024-12-13 kjlubick@google.com Remove unnecessary const qualifiers from single char params
2024-12-13 egdaniel@google.com [Graphite] Add public APIs for setting cache limits.
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e9b33f04020e to c75bd915ec7d (4 revisions)
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b56cde80dd49 to 034518ee55a5 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@skia-flutter-autoroll skia-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2024
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #57197 at sha 2408703

https://skia.googlesource.com/skia.git/+log/8c1e2bf9492c..8054b098b5cd

2024-12-13 kjlubick@google.com Update delaunator to read from GoB mirror
2024-12-13 kjlubick@google.com Remove unnecessary const qualifiers from single char params
2024-12-13 egdaniel@google.com [Graphite] Add public APIs for setting cache limits.
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e9b33f04020e to c75bd915ec7d (4 revisions)
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b56cde80dd49 to 034518ee55a5 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jason-simmons jason-simmons force-pushed the skia-flutter-autoroll-26d1a5e3-e0b1-4cf9-8c8f-23b41acc9fbc-1734120341 branch from 2408703 to 3fca47d Compare December 14, 2024 20:28
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 14, 2024
Copy link
Contributor

auto-submit bot commented Dec 14, 2024

auto label is removed for flutter/engine/57197, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 16, 2024
@auto-submit auto-submit bot merged commit 0dfbd04 into flutter:main Dec 16, 2024
36 checks passed
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 16, 2024
…160376)

flutter/engine@d373a93...0dfbd04

2024-12-16 skia-flutter-autoroll@skia.org Roll Skia from 8c1e2bf9492c to
8054b098b5cd (5 revisions) (flutter/engine#57197)
2024-12-16 goderbauer@google.com Reland 'Delete stale
package_config.json in gclient sync hook' (flutter/engine#57218)
2024-12-16 MyriadSoft@users.noreply.github.com docs: Fix RGB565 format
documentation and bit masks (flutter/engine#57210)
2024-12-16 jonahwilliams@google.com [Impeller] disable AHB swapchains on
all platforms. (flutter/engine#57213)
2024-12-16 jonahwilliams@google.com [Impeller] fix Adreno precision
issue in gaussian downsample. (flutter/engine#57212)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…gine#57197)

https://skia.googlesource.com/skia.git/+log/8c1e2bf9492c..8054b098b5cd

2024-12-13 kjlubick@google.com Update delaunator to read from GoB mirror
2024-12-13 kjlubick@google.com Remove unnecessary const qualifiers from single char params
2024-12-13 egdaniel@google.com [Graphite] Add public APIs for setting cache limits.
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from e9b33f04020e to c75bd915ec7d (4 revisions)
2024-12-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b56cde80dd49 to 034518ee55a5 (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@skia-flutter-autoroll skia-flutter-autoroll deleted the skia-flutter-autoroll-26d1a5e3-e0b1-4cf9-8c8f-23b41acc9fbc-1734120341 branch December 20, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App will affect goldens
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants