docs: Fix RGB565 format documentation and bit masks #57210
Conversation
…mat documentation incorrectly stated that red component uses the least significant bits. This commit fixes the documentation to correctly reflect that:\n\n- Red uses 5 MSBs [15:11]\n- Green uses 6 middle bits [10:5]\n- Blue uses 5 LSBs [4:0]\n\nAlso fixes the example bit extraction code to use correct masks.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
test-exempt: only affects comments |
There was a problem hiding this comment.
@MyriadSoft thanks for your patch. Looks like this was failing the formatting check. I've pushed a patch that reformats to appease the tests. Once those pass, we'll merge.
cbracken
added
the
autosubmit
…160376) flutter/engine@d373a93...0dfbd04 2024-12-16 skia-flutter-autoroll@skia.org Roll Skia from 8c1e2bf9492c to 8054b098b5cd (5 revisions) (flutter/engine#57197) 2024-12-16 goderbauer@google.com Reland 'Delete stale package_config.json in gclient sync hook' (flutter/engine#57218) 2024-12-16 MyriadSoft@users.noreply.github.com docs: Fix RGB565 format documentation and bit masks (flutter/engine#57210) 2024-12-16 jonahwilliams@google.com [Impeller] disable AHB swapchains on all platforms. (flutter/engine#57213) 2024-12-16 jonahwilliams@google.com [Impeller] fix Adreno precision issue in gaussian downsample. (flutter/engine#57212) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…7210) The RGB565 format documentation in embedder.h incorrectly stated that the red component uses the least significant bits. Unit tests in embedder/testdefs/embedder_unittests.cc demonstrate this is incorrect, showing: - Red test (0xF800): Uses bits [15:11] - Green test (0x07E0): Uses bits [10:5] - Blue test (0x001F): Uses bits [4:0] This commit fixes the documentation to correctly reflect the actual bit layout: - Red uses 5 MSBs [15:11] - Green uses 6 middle bits [10:5] - Blue uses 5 LSBs [4:0] Also fixes the example bit extraction code to use correct masks, matching the test expectations. Impact: This change helps prevent potential developer confusion about RGB565 bit ordering and ensures the documentation matches the actual implementation as verified by the test suite.
The RGB565 format documentation in embedder.h incorrectly stated that the red component uses the least significant bits. Unit tests in embedder/testdefs/embedder_unittests.cc demonstrate this is incorrect, showing:
This commit fixes the documentation to correctly reflect the actual bit layout:
Also fixes the example bit extraction code to use correct masks, matching the test expectations.
Impact: This change helps prevent potential developer confusion about RGB565 bit ordering and ensures the documentation matches the actual implementation as verified by the test suite.