Update Android plugin templates for newer AGP #156533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Flutter requires AGP 7+, we can use Java 11 as the compatibility version in the plugin template rather than 1.8, avoiding warnings with newer toolchains, and we can remove the check for 'namespace' existing that was only necessary to support AGP 4.1. See also flutter/packages#7795 which made this change in Flutter-team-owned plugins. Part of flutter#156111
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
tool
gmackall
approved these changes
Oct 10, 2024
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 10, 2024
flutter/flutter@2d45fb3...6790525 2024-10-10 engine-flutter-autoroll@skia.org Roll Packages from 9d00fb1 to f1a3da2 (5 revisions) (flutter/flutter#156538) 2024-10-10 stuartmorgan@google.com Update Android plugin templates for newer AGP (flutter/flutter#156533) 2024-10-10 dacoharkes@google.com Flutter templates example app Gradle memory settings (flutter/flutter#156201) 2024-10-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3a95d6e1ddbf to 590babc1581b (1 revision) (flutter/flutter#156498) 2024-10-10 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Unskip cupertino datepicker tests (flutter/flutter#156499) 2024-10-10 32538273+ValentinVignal@users.noreply.github.com Add test for animated list example (flutter/flutter#156452) 2024-10-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from fb0b59d9438b to 3a95d6e1ddbf (1 revision) (flutter/flutter#156492) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
stuartmorgan
added
the
cp: beta
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Oct 17, 2024
Now that Flutter requires AGP 7+, we can use Java 11 as the compatibility version in the plugin template rather than 1.8, avoiding warnings with newer toolchains, and we can remove the check for 'namespace' existing that was only necessary to support AGP 4.1. See also flutter/packages#7795 which made this change in Flutter-team-owned plugins. Part of flutter#156111
eyebrowsoffire
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Nov 13, 2024
Now that Flutter requires AGP 7+, we can use Java 11 as the compatibility version in the plugin template rather than 1.8, avoiding warnings with newer toolchains, and we can remove the check for 'namespace' existing that was only necessary to support AGP 4.1. See also flutter/packages#7795 which made this change in Flutter-team-owned plugins. Part of flutter#156111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Flutter requires AGP 7+, we can use Java 11 as the compatibility version in the plugin template rather than 1.8, avoiding warnings with newer toolchains, and we can remove the check for 'namespace' existing that was only necessary to support AGP 4.1.
See also flutter/packages#7795 which made this change in Flutter-team-owned plugins.
Part of #156111
Pre-launch Checklist
///).