Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon] fixed cases where types can be missing from codecs #468

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Sep 14, 2021

Previously we fixed that classes are generated when referenced only from type arguments, we were still missing them from the codec though. This fixes that.

fixes internal question 4652416327166722048

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke force-pushed the pigeon-missing-codec-pieces branch from 73e4290 to 22bb643 Compare September 14, 2021 22:31
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman
Copy link
Member

ditman commented Sep 15, 2021

I'll land this after #469 lands to see if the repo goes back to green!

@ditman
Copy link
Member

ditman commented Sep 15, 2021

Landing to test the auto-publish script.

@ditman ditman merged commit 9c51794 into flutter:master Sep 15, 2021
@ditman
Copy link
Member

ditman commented Sep 15, 2021

Uploading...

Successfully uploaded package.

Package published!
Tagging release pigeon-v1.0.4...
Pushing tag to origin...
Release tagged!

Published pigeon successfully!

@gaaclarke
Copy link
Member Author

Thanks @ditman, I actually couldn't sleep so I decided to try to get this landed since it was bugging me. I'm happy to see it already done. Guess I'll go back to staring at the wall haha.

@ditman
Copy link
Member

ditman commented Sep 15, 2021

Apologies @gaaclarke for depriving you of this midnight pastime! (Landing this was a very convenient way of testing the CI on packages/plugins, that had been on fire for the whole day!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants