Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Give write permissions to release.yml #469

Merged
merged 1 commit into from
Sep 15, 2021
Merged

[ci] Give write permissions to release.yml #469

merged 1 commit into from
Sep 15, 2021

Conversation

ditman
Copy link
Member

@ditman ditman commented Sep 15, 2021 •
edited
Loading

Give write permissions to the repo to the release action, so it can push a new tag to it after publishing a package.

Partial fix for: flutter/flutter#90095

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Sep 15, 2021
stuartmorgan
stuartmorgan approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a speculative fix. Maybe land #468 right after as a test?

@ditman
Copy link
Member Author

ditman commented Sep 15, 2021

LGTM as a speculative fix. Maybe land #468 right after as a test?

@stuartmorgan can do.

@ditman ditman mentioned this pull request Sep 15, 2021
Merged
11 tasks
@ditman
Copy link
Member Author

ditman commented Sep 15, 2021

Landing on red now to see if the next push publishes correctly.

@ditman ditman merged commit 064afdd into flutter:master Sep 15, 2021
@ditman ditman deleted the permissions-for-release branch September 15, 2021 02:22
@ditman
Copy link
Member Author

ditman commented Sep 15, 2021 •
edited
Loading

Ah, @stuartmorgan the effects on this can be seen in the Github Action logs, link:

Screen Shot 2021-09-14 at 7 23 48 PM

Compare with a previous successful run.

stuartmorgan pushed a commit that referenced this pull request Oct 31, 2024
@srawlins
eturn valid type from Future.catchError. (#469)
f3d4f00 
An upcoming feature to the Dart analyzer [0] will report Future.catchError [1]
`onError` handlers which return values of invalid type. Currently this is not
reported because the `onError` handler function type cannot be accurately
expressed. An `onError` handler for `Future<T>.catchError` must be either
`FutureOr<T> Function(dynamic)` or `FutureOr<T> Function(dynamic, StackTrace)`.
In either case, the return type of the function is `FutureOr<T>`.

This CL corrects `onError` handler(s) to return a value of a valid type.

[0]: dart-lang/sdk#35825
[1]: https://api.dart.dev/dev/2.12.0-149.0.dev/dart-async/Future/catchError.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ditman @stuartmorgan