[pigeon] Swift implementation for ProxyApis #6602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
bparrishMines
requested review from
hellohuanlin,
LouiseHsu and
tarrinneal
as code owners
stuartmorgan
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
LGTM, but please wait for Tarrin's approval on the generator changes.
I did a relatively light review pass here, but the the instance manager looks like I expect from the Obj-C webview_flutter prototype, and the overall structure and the availability annotations make sense to me.
tarrinneal
approved these changes
Oct 4, 2024
Comment on lines
731
to
736
| indent.format(instanceManagerFinalizerDelegateTemplate(generatorOptions)); | ||
| indent.newln(); | ||
| indent.format(instanceManagerFinalizerTemplate(generatorOptions)); | ||
| indent.newln(); | ||
| indent.format(instanceManagerTemplate(generatorOptions)); | ||
| indent.newln(); |
There was a problem hiding this comment.
might be better to just add the new lines into the templates
| return apis.isNotEmpty ? 'available(${apis.join(', ')}, *)' : null; | ||
| } | ||
|
|
||
| /// Recursively iterates |
There was a problem hiding this comment.
I think it does more than this? Either way, needs a period.
hellohuanlin
reviewed
Oct 7, 2024
| _ = instanceManager.addHostCreatedInstance(object) | ||
|
|
||
| let identifier = instanceManager.identifierWithStrongReference(forInstance: object) | ||
| XCTAssertNotNil(identifier) |
There was a problem hiding this comment.
optional nit: can use XCTUnwrap to avoid !. When it's nil, instead of crashing, it would mark it as a test failure and continue with other tests.
There was a problem hiding this comment.
I changed the following line to:
XCTAssertEqual(instanceManager.instance(forIdentifier: try XCTUnwrap(identifier)), object)Is that what you were thinking? The XCTAssertNotNil(identifier) check also fails the test but continues to run other tests.
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 14, 2024
flutter/packages@67401e1...1e670f2 2024-10-14 stuartmorgan@google.com [image_picker] Update for non-nullable generics in Pigeon (flutter/packages#7775) 2024-10-14 109111084+yaakovschectman@users.noreply.github.com [camera_android] Convert calls from native to dart side to Pigeon. (flutter/packages#7857) 2024-10-14 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Update JSON code to Pigeon for `BitmapDescriptor`, `Cap`, and `PatternItem` (flutter/packages#7840) 2024-10-13 andrechalella@gmail.com [flutter_markdown] Soft wrapping in blockquotes (flutter/packages#7848) 2024-10-12 stuartmorgan@google.com [google_maps_flutter] Update iOS Pigeon for non-nullable generics (flutter/packages#7792) 2024-10-11 10687576+bparrishMines@users.noreply.github.com [pigeon] Swift implementation for ProxyApis (flutter/packages#6602) 2024-10-11 echo.ellet@gmail.com [camera_android_camerax] Remove duplicated 'report' in README.md (flutter/packages#7708) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift portion of flutter/flutter#134777
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.