Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_maps_flutter_android] Update JSON code to Pigeon for BitmapDescriptor, Cap, and PatternItem #7840

Merged
merged 16 commits into from
Oct 14, 2024

Conversation

yaakovschectman
Copy link
Contributor

Replace the old untyped implementations with typesafe approaches using the recently updated platform interface.

Parts of flutter/flutter#155122, flutter/flutter#154737, and flutter/flutter#155121

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@yaakovschectman yaakovschectman marked this pull request as ready for review October 10, 2024 17:43
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just some small comments. It's great to see all the Dart JSON code going away!

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaakovschectman yaakovschectman merged commit c4d8010 into flutter:main Oct 14, 2024
76 checks passed
@yaakovschectman yaakovschectman deleted the maps_pigeon_bitmap branch October 14, 2024 15:59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 14, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 14, 2024
flutter/packages@67401e1...1e670f2

2024-10-14 stuartmorgan@google.com [image_picker] Update for non-nullable generics in Pigeon (flutter/packages#7775)
2024-10-14 109111084+yaakovschectman@users.noreply.github.com [camera_android] Convert calls from native to dart side to Pigeon. (flutter/packages#7857)
2024-10-14 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_android] Update JSON code to Pigeon for `BitmapDescriptor`, `Cap`, and `PatternItem` (flutter/packages#7840)
2024-10-13 andrechalella@gmail.com [flutter_markdown] Soft wrapping in blockquotes (flutter/packages#7848)
2024-10-12 stuartmorgan@google.com [google_maps_flutter] Update iOS Pigeon for non-nullable generics (flutter/packages#7792)
2024-10-11 10687576+bparrishMines@users.noreply.github.com [pigeon] Swift implementation for ProxyApis (flutter/packages#6602)
2024-10-11 echo.ellet@gmail.com [camera_android_camerax] Remove duplicated 'report' in README.md (flutter/packages#7708)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants