Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_adaptive_scaffold] Compare breakpoints #7531

Merged
merged 12 commits into from
Aug 30, 2024

Conversation

martijn00
Copy link
Contributor

@martijn00 martijn00 commented Aug 29, 2024

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

Sometimes you want to compare a breakpoint to a baseline or another breakpoint to determine which UI to show or how to handle something. This adds operators so you can check those things.

Breakpoint.activeBreakpointOf(context) > Breakpoints.large;

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

This comment was marked as resolved.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

packages/flutter_adaptive_scaffold/README.md Show resolved Hide resolved
@martijn00
Copy link
Contributor Author

@Renzo-Olivares can you review?

Copy link

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2024
@auto-submit auto-submit bot merged commit 848d7e9 into flutter:main Aug 30, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 3, 2024
flutter/packages@c9c0004...848d7e9

2024-08-30 mhvdijk@gmail.com [flutter_adaptive_scaffold] Compare breakpoints (flutter/packages#7531)
2024-08-30 tarrinneal@gmail.com [pigeon] adds support for collections of enums and classes (flutter/packages#7476)
2024-08-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes bug where ad can replay during content playback (flutter/packages#7537)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_adaptive_scaffold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants