[interactive_media_ads] Fixes bug where ad can replay during content playback #7537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-android
platform-ios
p: interactive_media_ads
bparrishMines
changed the title
Merged
11 tasks
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 3, 2024
flutter/packages@c9c0004...848d7e9 2024-08-30 mhvdijk@gmail.com [flutter_adaptive_scaffold] Compare breakpoints (flutter/packages#7531) 2024-08-30 tarrinneal@gmail.com [pigeon] adds support for collections of enums and classes (flutter/packages#7476) 2024-08-30 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Fixes bug where ad can replay during content playback (flutter/packages#7537) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the VideoView: "VideoView does not retain its full state when going into the background."
This also seems to include the
onCompletestate. So even after theonCompletecallback was triggered, theonPreparedcallback would trigger if the the app is sent to the background and then the foreground.This is fixed by setting the video URI to
nullonce the ad is signaled to stop by the IMA SDK.I also considered setting the value to
nullin theonComplete/onErrorcallbacks, but I assume these callbacks will always trigger thestopAdcallback from the SDK (this seems to be true when I tested it). Making the calls redundant.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.