Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon] chore(readme): deprecated command of running pigeon #7761

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

EchoEllet
Copy link
Contributor

@EchoEllet EchoEllet commented Oct 2, 2024

Update outdated command in README.md of running pigeon.

Same as #7709

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@EchoEllet
Copy link
Contributor Author

In #7709 we didn't add a CHANGELOG entry documenting this change (see this comment). Let me know if CHANGELOG.md entry is necessary for this change.

@EchoEllet EchoEllet marked this pull request as ready for review October 2, 2024 09:40
@EchoEllet EchoEllet requested a review from tarrinneal as a code owner October 2, 2024 09:40
@stuartmorgan
Copy link
Contributor

Let me know if CHANGELOG.md entry is necessary for this change.

Please see the first entry in https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#faq

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@EchoEllet EchoEllet marked this pull request as draft October 2, 2024 12:29
@EchoEllet EchoEllet marked this pull request as ready for review October 2, 2024 12:37
@stuartmorgan
Copy link
Contributor

stuartmorgan commented Oct 2, 2024

test-exempt: readme-only change; bot false positive due to having the package version in the code

Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

packages/pigeon/CHANGELOG.md Outdated Show resolved Hide resolved
@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2024
@auto-submit auto-submit bot merged commit ff456a1 into flutter:main Oct 3, 2024
76 checks passed
@EchoEllet
Copy link
Contributor Author

Thank you

Thank you, too, for the review. I will ensure to read the full guidelines next time.

@EchoEllet EchoEllet deleted the patch-2 branch October 3, 2024 12:17
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 3, 2024
flutter/packages@7c97c88...429650f

2024-10-03 34871572+gmackall@users.noreply.github.com [camera, google_sign_in, espresso] Bump guava to version `33.3.1`. (flutter/packages#7773)
2024-10-03 stuartmorgan@google.com [video_player] Remove -Werror from Android build (flutter/packages#7776)
2024-10-03 echo.ellet@gmail.com [pigeon] chore(readme): deprecated command of running pigeon (flutter/packages#7761)
2024-10-02 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.9.1 to 1.9.2 in /packages/image_picker/image_picker_android/android (flutter/packages#7607)
2024-10-02 43759233+kenzieschmoll@users.noreply.github.com Add percentile computations to benchmark scores (flutter/packages#7760)
2024-10-02 stuartmorgan@google.com [various] Unpin some dev dependencies (flutter/packages#7762)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: pigeon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants