Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon] chore(readme): deprecated command of running pigeon #7761

Merged
merged 7 commits into from
Oct 3, 2024
+7 −3
Merged

[pigeon] chore(readme): deprecated command of running pigeon #7761

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2aa9ce
[pigeon] chore(readme): deprecated command of running pigeon
EchoEllet Oct 2, 2024
7535068
chore(version): update version to 22.4.2, add CHANGELOG entry
EchoEllet Oct 2, 2024
340e196
chore: update CHANGELOG.md entry item for clarity
EchoEllet Oct 2, 2024
14d8239
test(readme): add minimal test to ensure not to use deprecated comman…
EchoEllet Oct 2, 2024
fd1d946
chore(test): remove unnecessary README test
EchoEllet Oct 2, 2024
b69923a
chore(readme): update CHANGELOG.md entry for consistency
EchoEllet Oct 2, 2024
23f52bf
chore(changelog): use 'Updates' instead of 'Changes'
EchoEllet Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pigeon/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 22.4.2

* Update README.md to use `dart run pigeon` instead of the deprecated command `flutter pub run pigeon`.
EchoEllet marked this conversation as resolved.
Show resolved Hide resolved

## 22.4.1

* [dart] Fixes bug where special handling of ints is ignored if no custom types are used.
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ to the api to allow for multiple instances to be created and operate in parallel
1) Make a ".dart" file outside of your "lib" directory for defining the
communication interface.
1) Run pigeon on your ".dart" file to generate the required Dart and
host-language code: `flutter pub get` then `flutter pub run pigeon`
host-language code: `flutter pub get` then `dart run pigeon`
with suitable arguments. [Example](./example/README.md#Invocation).
1) Add the generated Dart code to `./lib` for compilation.
1) Implement the host-language code and add it to your build (see below).
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/lib/generator_tools.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import 'ast.dart';
/// The current version of pigeon.
///
/// This must match the version in pubspec.yaml.
const String pigeonVersion = '22.4.1';
const String pigeonVersion = '22.4.2';

/// Read all the content from [stdin] to a String.
String readStdin() {
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: pigeon
description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
repository: https://github.com/flutter/packages/tree/main/packages/pigeon
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pigeon%22
version: 22.4.1 # This must match the version in lib/generator_tools.dart
version: 22.4.2 # This must match the version in lib/generator_tools.dart

environment:
sdk: ^3.3.0
Expand Down