Use dependabot multi-directory configuration for Android example gradle updates #8036
Conversation
jmagman
changed the title
| commit-message: | ||
| prefix: "[animations]" | ||
| prefix: "[gradle]" |
There was a problem hiding this comment.
@stuartmorgan @reidbaker This change would mean we lose the PR title prefix, which is unfortunate. This seems worth it, but maybe some tooling/bot is relying on this prefix matching a package name?
There was a problem hiding this comment.
maybe some tooling/bot is relying on this prefix matching a package name?
Shouldn't be, the prefixing convention in the repo is just for our convenience when wading through PRs and issues.
This PR doesn't implement This PR is only to deduplicate the configs (nicer anyway) so I can start adding groups in one place common across all packages. I'll work with Reid to figure out which |
|
Thanks, I totally missed that distinction :) (I suspect a group for all example apps would actually be pretty nice.) |
I think this change will also mean for a given dependency bump there will be one PR that updates all the packages, instead of one PR per package. I'm not 100% sure though, we can see what it does... |
That's what I thought originally. If so, almost certainly good for examples, TBD for non-examples. |
|
Wait, is dependabot working at all for examples? I know it's only supposed to work for major versions, but I see zero dependabot PRs bumping it. Example commit history https://github.com/flutter/packages/commits/main/packages/google_maps_flutter/google_maps_flutter/example/android/app/build.gradle
|
jmagman
changed the title
jmagman
force-pushed
the
dependabot-gradle
branch
from
6d90444
to
12d669a
Compare
|
I'm going to swap this to just update the examples, though it seems like dependabot hasn't actually been needed to update the major versions (or possibly isn't working?). Reid suggests we should do all of them and see what happens, so I'll follow up the rest in another PR that we can easily revert. |
auto-submit
bot
removed
the
autosubmit
…ample gradle updates (flutter/packages#8036)
…tes (#8048) Follow up to #8036 (comment). [Multi-directory config](https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#directories) allows duplicated dependabot configs can be removed in favor of one that specifies multiple directories. Update Android packages so the same gradle dependencies can be updated all at once across packages. > The directories option in the dependabot.yml file allows you to apply Dependabot updates to multiple directories at the same time. It's unclear whether this is a good idea. > I'm a bit skeptical that grouping all the non-example ones together will be easier in practice, since usually some plugins are fine and some need changes, but I know the current system has some issues too. #8036 (review) The consensus seems to be we should try it, and revert or adjust if it makes the current system worse. Part of flutter/flutter#148098
…ample gradle updates (flutter/packages#8036)
…ample gradle updates (flutter/packages#8036)
…ample gradle updates (flutter/packages#8036)
…ample gradle updates (flutter/packages#8036)
flutter/packages@72356fd...26e123a 2024-11-13 dasyad00@gmail.com [camera_windows] Set device media type for video preview explicitly (flutter/packages#7447) 2024-11-13 39979207+ThangVuNguyenViet@users.noreply.github.com [go_router] Add support for relative routes (flutter/packages#6825) 2024-11-13 pq@users.noreply.github.com [vector_graphics_compiler] fix a renamed method parameter lint (flutter/packages#8070) 2024-11-12 feinstein@users.noreply.github.com [in_app_purchase] Add expiration date to Transaction (flutter/packages#8030) 2024-11-12 stuartmorgan@google.com [various] Clean up contributing guides (flutter/packages#8032) 2024-11-12 ditman@gmail.com [ci] Remove web renderer option from tools. (flutter/packages#8055) 2024-11-12 stuartmorgan@google.com [url_launcher] Update Pigeon version for Linux (flutter/packages#8065) 2024-11-12 tobias@leafnode.se [go_router] Add support for preloading branches of StatefulShellRoute (revised solution) (flutter/packages#6467) 2024-11-12 stuartmorgan@google.com [pigeon] Make Linux type declarations public (flutter/packages#8040) 2024-11-11 engine-flutter-autoroll@skia.org Roll Flutter from 73546b3 to c8510f2 (30 revisions) (flutter/packages#8042) 2024-11-11 magder@google.com Use dependabot multi-directory configuration for Android package updates (flutter/packages#8048) 2024-11-11 stuartmorgan@google.com [tools] Run `pub get` before `format` (flutter/packages#8052) 2024-11-11 stuartmorgan@google.com [file_selector] Fix Linux cancel regression (flutter/packages#8051) 2024-11-09 stuartmorgan@google.com [shared_preferences] Fix confusing language in README (flutter/packages#8049) 2024-11-08 magder@google.com Use dependabot multi-directory configuration for Android example gradle updates (flutter/packages#8036) 2024-11-08 43054281+camsim99@users.noreply.github.com [animations] Remove `.flutter-plugins` reference from example app (flutter/packages#8002) 2024-11-08 magder@google.com Group dependabot github-action update PRs, delete dead docker updates (flutter/packages#8044) 2024-11-08 37028599+EArminjon@users.noreply.github.com [vector_graphics_compiler] fix-null-exception (flutter/packages#8006) 2024-11-08 stuartmorgan@google.com [tools] Format Dart per-package (flutter/packages#8043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Multi-directory config allows duplicated dependabot configs can be removed in favor of one that specifies multiple directories. Update the Android example apps so they can be updated all at once.
Also updated the dependabot CI command to look for either
directoryordirectorieskey.Part of flutter/flutter#148098
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.